Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: icu4c 64.2 #26388

Closed
srl295 opened this issue Mar 2, 2019 · 6 comments
Closed

deps: icu4c 64.2 #26388

srl295 opened this issue Mar 2, 2019 · 6 comments
Assignees
@ryzokuken
Labels
i18n-api Issues and PRs related to the i18n implementation.

Comments

@srl295
Copy link
Member

srl295 commented Mar 2, 2019

Followon to #23244

  • Platform: all
  • Subsystem: deps

ICU 64 updates to Unicode 12 and to CLDR 35 locale data with many additions and corrections, and some new languages. ICU adds a data filtering/subsetting mechanism, improved formatting API, and a C++ LocaleBuilder.
@srl295 srl295 self-assigned this Mar 2, 2019
@srl295 srl295 added the i18n-api Issues and PRs related to the i18n implementation. label Mar 2, 2019
@srl295
Copy link
Member Author

srl295 commented Mar 2, 2019

release candidate pushed to branch^

@srl295 srl295 mentioned this issue Mar 2, 2019
Closed
4 tasks
srl295 added a commit to srl295/node that referenced this issue Mar 11, 2019
@srl295
deps: icu 64 RC
438759a 
🚧 WORK IN PROGRESS

For: nodejs#26388
@srl295
Copy link
Member Author

srl295 commented Apr 3, 2019

at this point, probably may as well wait for 64.2… includes the Reiwa era support

@srl295
Copy link
Member Author

srl295 commented Apr 12, 2019

ICU 64.2 RC was released today https://github.com/unicode-org/icu/releases/tag/release-64-2-rc

@targos
Copy link
Member

targos commented Apr 17, 2019

V8 already seems to depend on ICU 64 and so our canary builds are broken until we update:

  g++ -o /home/mzasso/git/nodejs/canary/out/Release/obj.target/v8_base/deps/v8/src/objects/intl-objects.o ../deps/v8/src/objects/intl-objects.cc '-DV8_GYP_BUILD' '-DV8_TYPED_ARRAY_MAX_SIZE_IN_HEAP=64' '-DOPENSSL_THREADS' '-DV8_TARGET_ARCH_X64' '-DV8_EMBEDDER_STRING="-node.0"' '-DENABLE_DISASSEMBLER' '-DV8_PROMISE_INTERNAL_FIELD_COUNT=1' '-DENABLE_MINOR_MC' '-DV8_INTL_SUPPORT' '-DV8_USE_SNAPSHOT' '-DV8_CONCURRENT_MARKING' '-DV8_EMBEDDED_BUILTINS' '-DV8_USE_SIPHASH' '-DDISABLE_UNTRUSTED_CODE_MITIGATIONS' '-DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_STATIC' '-DUCONFIG_NO_SERVICE=1' '-DU_ENABLE_DYLOAD=0' '-DU_STATIC_IMPLEMENTATION=1' '-DU_HAVE_STD_STRING=1' '-DUCONFIG_NO_BREAK_ITERATION=0' -I../deps/v8 -I../deps/v8/include -I/home/mzasso/git/nodejs/canary/out/Release/obj/gen/generate-bytecode-output-root -I/home/mzasso/git/nodejs/canary/out/Release/obj/gen/torque-output-root -I/home/mzasso/git/nodejs/canary/out/Release/obj/gen/inspector-generated-output-root -I../deps/icu-small/source/i18n -I../deps/icu-small/source/common  -pthread -Wno-unused-parameter -m64 -fno-strict-aliasing -m64 -O3 -fno-omit-frame-pointer -fdata-sections -ffunction-sections -O3 -fno-rtti -fno-exceptions -std=gnu++1y -MMD -MF /home/mzasso/git/nodejs/canary/out/Release/.deps//home/mzasso/git/nodejs/canary/out/Release/obj.target/v8_base/deps/v8/src/objects/intl-objects.o.d.raw   -c
../deps/v8/src/objects/intl-objects.cc:45:28: error: static assertion failed: v8 is required to build with ICU 64 and up
     V8_MINIMUM_ICU_VERSION <= U_ICU_VERSION_MAJOR_NUM,

@srl295
Copy link
Member Author

srl295 commented Apr 19, 2019

@targos huh, did not know that 64 was made to be a requirement.

64.2 is now GA, anyone want to give this a try? @refack @ryzokuken ?

@srl295 srl295 added the help wanted Issues that need assistance from volunteers or PRs that need help to proceed. label Apr 19, 2019
@srl295
Copy link
Member Author

srl295 commented Apr 19, 2019 •
edited
Loading

  • I've published the full-icu (icu4c-data) packages for 64.

@srl295 srl295 changed the title deps: icu4c 64.1 deps: icu4c 64.2 Apr 19, 2019
@srl295 srl295 assigned ryzokuken and unassigned refack and srl295 Apr 22, 2019
@srl295 srl295 removed the help wanted Issues that need assistance from volunteers or PRs that need help to proceed. label Apr 22, 2019
@ryzokuken ryzokuken mentioned this issue Apr 23, 2019
Closed
3 tasks
ryzokuken added a commit to ryzokuken/node that referenced this issue Apr 23, 2019
@ryzokuken
deps: update ICU to 64.2
b72fc90 
Update the version of the bundled ICU (deps/icu-small) to ICU version
64.2 (Unicode 12, CLDR 35)

Fixes: nodejs#26388
@targos targos closed this as completed in c9b298c Apr 25, 2019
targos pushed a commit that referenced this issue Apr 25, 2019
@ryzokuken @targos
tools: update LICENSE and tools/icu/current_ver.dep
c80c414 
Update the LICENSE file and tools/icu/current_ver.dep file in order to
finalize the upgrade to ICU 64.2

PR-URL: #27361
Fixes: #26388
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Steven R Loomis <srloomis@us.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
targos pushed a commit that referenced this issue Apr 27, 2019
@ryzokuken @targos
deps: update ICU to 64.2
d852d9e 
Update the version of the bundled ICU (deps/icu-small) to ICU version
64.2 (Unicode 12, CLDR 35)

Fixes: #26388

PR-URL: #27361
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Steven R Loomis <srloomis@us.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
targos pushed a commit that referenced this issue Apr 27, 2019
@ryzokuken @targos
tools: update LICENSE and tools/icu/current_ver.dep
53f0ef3 
Update the LICENSE file and tools/icu/current_ver.dep file in order to
finalize the upgrade to ICU 64.2

PR-URL: #27361
Fixes: #26388
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Steven R Loomis <srloomis@us.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
BethGriggs pushed a commit that referenced this issue May 10, 2019
@ryzokuken @BethGriggs
deps: update ICU to 64.2
ea6a0ad 
Update the version of the bundled ICU (deps/icu-small) to ICU version
64.2 (Unicode 12, CLDR 35)

Fixes: #26388

PR-URL: #27361
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Steven R Loomis <srloomis@us.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
BethGriggs pushed a commit that referenced this issue May 10, 2019
@ryzokuken @BethGriggs
tools: update LICENSE and tools/icu/current_ver.dep
3c8787b 
Update the LICENSE file and tools/icu/current_ver.dep file in order to
finalize the upgrade to ICU 64.2

PR-URL: #27361
Fixes: #26388
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Steven R Loomis <srloomis@us.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
MylesBorins pushed a commit that referenced this issue May 16, 2019
@ryzokuken @MylesBorins
deps: update ICU to 64.2
c9d0b6a 
Update the version of the bundled ICU (deps/icu-small) to ICU version
64.2 (Unicode 12, CLDR 35)

Fixes: #26388

PR-URL: #27361
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Steven R Loomis <srloomis@us.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
MylesBorins pushed a commit that referenced this issue May 16, 2019
@ryzokuken @MylesBorins
tools: update LICENSE and tools/icu/current_ver.dep
0fd4b35 
Update the LICENSE file and tools/icu/current_ver.dep file in order to
finalize the upgrade to ICU 64.2

PR-URL: #27361
Fixes: #26388
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Steven R Loomis <srloomis@us.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@srl295 srl295 mentioned this issue Sep 12, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ryzokuken ryzokuken

Labels
i18n-api Issues and PRs related to the i18n implementation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

deps: update ICU to 64.2 ryzokuken/node
4 participants
@refack @srl295 @targos @ryzokuken