Assertion Failure

[isaacs]

Seeing this new thing in the node-tap tests:

  Assertion failed: ((static_cast<size_t>(off - 1)) <= (sizeof(arrow) - 1)),
  function AppendExceptionLine, file ../src/node.cc, line 1404.

[evanlucas]

I just started seeing that this morning also :/

[Fishrock123]

What version? master?

[evanlucas]

3.2.0 for me

[isaacs]

@Fishrock123 3.2.0

Looks like this happens when it tries to pretty-print a thrown error in some cases.

[evanlucas]

I can reproduce with ./node -pe 'JSON.parse(\'{"name":"asdfasdfasdfsadfasdf,fasfsafd,asdfffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffasdfffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffasdfasdfkjasdl;fkjal;skdjfl;aksdjflkasjdfl;kajsdlf;kjasldkfjal;sdkjf;lasdjfl;kasjfdl;kajsdf;lsajld;fkjasl;dfjal;sdfkjl;sfffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffad\'"}\')'

[isaacs]

Reduced case: https://gist.github.com/isaacs/832dbcf3e9e22574989d

First release with the error is 3.0.0, so it's been around a little while.

[skomski]

Opened a PR for this 11 days ago: #2404

[evanlucas]

@isaacs are you still able to reproduce this on v4.0.0?

[skomski]

Can be closed fixed by #2404.

[evanlucas]

Thanks @skomski!