Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: os.networkInterfaces() example outdated #25408

Closed
mscdex opened this issue Jan 9, 2019 · 1 comment
Closed

doc: os.networkInterfaces() example outdated #25408

mscdex opened this issue Jan 9, 2019 · 1 comment
Labels
doc Issues and PRs related to the documentations. good first issue Issues that are suitable for first-time contributors. os Issues and PRs related to the os subsystem.

Comments

@mscdex
Copy link
Contributor

mscdex commented Jan 9, 2019

  • Version: master
  • Platform: n/a
  • Subsystem: doc

The os.networkInterfaces() example is outdated as the IPv6 interfaces do not include the scopeid property.
@mscdex mscdex added doc Issues and PRs related to the documentations. os Issues and PRs related to the os subsystem. good first issue Issues that are suitable for first-time contributors. labels Jan 9, 2019
@jvelezpo
Copy link
Contributor

jvelezpo commented Jan 9, 2019

i will work on it this afternoon 😎

@jvelezpo jvelezpo mentioned this issue Jan 9, 2019
Closed
3 tasks
addaleax pushed a commit that referenced this issue Jan 14, 2019
@jvelezpo @addaleax
doc: update os.networkInterfaces() example
177635b 
The os.networkInterfaces() example was outdated
as the IPv6 interfaces did not include the scopeid property,
now they do.

PR-URL: #25417
Fixes: #25408
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Weijia Wang <starkwang@126.com>
BridgeAR pushed a commit to BridgeAR/node that referenced this issue Jan 16, 2019
@jvelezpo @BridgeAR
doc: update os.networkInterfaces() example
f101222 
The os.networkInterfaces() example was outdated
as the IPv6 interfaces did not include the scopeid property,
now they do.

PR-URL: nodejs#25417
Fixes: nodejs#25408
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Weijia Wang <starkwang@126.com>
BethGriggs pushed a commit that referenced this issue Apr 28, 2019
@jvelezpo @BethGriggs
doc: update os.networkInterfaces() example
614edcb 
The os.networkInterfaces() example was outdated
as the IPv6 interfaces did not include the scopeid property,
now they do.

PR-URL: #25417
Fixes: #25408
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Weijia Wang <starkwang@126.com>
BethGriggs pushed a commit that referenced this issue May 10, 2019
@jvelezpo @BethGriggs
doc: update os.networkInterfaces() example
46711c7 
The os.networkInterfaces() example was outdated
as the IPv6 interfaces did not include the scopeid property,
now they do.

PR-URL: #25417
Fixes: #25408
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Weijia Wang <starkwang@126.com>
MylesBorins pushed a commit that referenced this issue May 16, 2019
@jvelezpo @MylesBorins
doc: update os.networkInterfaces() example
3a30c87 
The os.networkInterfaces() example was outdated
as the IPv6 interfaces did not include the scopeid property,
now they do.

PR-URL: #25417
Fixes: #25408
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Weijia Wang <starkwang@126.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. good first issue Issues that are suitable for first-time contributors. os Issues and PRs related to the os subsystem.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mscdex @jvelezpo