-
Notifications
You must be signed in to change notification settings - Fork 30.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tabs in the repl cause display issues #25272
Comments
It's weird because shows a very long space (as tab), but delete (looks like) works like spaces |
I guess the cursor position movement doesn't take care of tabs here. Will check this sometime. |
Ok I had taken a look, there are few things we can do:
I would suggest 1 as there is no way user can emit |
PR-URL: nodejs#31112 Fixes: nodejs#25272 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Just copy something like
var abc = 5;
in the repl and go back and forth and remove or add some characters. Push enter and go up and down in the history and further issues will resolve.The marker is not correct and sometimes things are not visible that should be and the other way around.
I guess we could either just display tabs as space (that would likely resolve the problem easily) orWe have to properly fix this and to teach the code to jump to the correct position if there's a tab.
The text was updated successfully, but these errors were encountered: