Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flaky: test-worker-uncaught-exception #23873

Closed
refack opened this issue Oct 25, 2018 · 4 comments
Closed

flaky: test-worker-uncaught-exception #23873

refack opened this issue Oct 25, 2018 · 4 comments
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. test Issues and PRs related to the tests. windows Issues and PRs related to the Windows platform. worker Issues and PRs related to Worker support.

Comments

@refack
Copy link
Contributor

refack commented Oct 25, 2018

https://ci.nodejs.org/job/node-test-binary-windows/21029/COMPILED_BY=vs2017-x86,RUNNER=win2012r2,RUN_SUBSET=2/console

07:57:48 not ok 529 parallel/test-worker-uncaught-exception
07:57:48   ---
07:57:48   duration_ms: 120.71
07:57:48   severity: fail
07:57:48   exitcode: 1
07:57:48   stack: |-
07:57:48     timeout
07:57:48     foo
07:57:48   ...
  • Platform: Windows
@refack refack added windows Issues and PRs related to the Windows platform. test Issues and PRs related to the tests. flaky-test Issues and PRs related to the tests with unstable failures on the CI. worker Issues and PRs related to Worker support. labels Oct 25, 2018
@refack refack mentioned this issue Oct 25, 2018
Closed
3 tasks
@Trott
Copy link
Member

Trott commented Oct 25, 2018

Since Rackspace vs. Azure is often a relevant thing on our Windows failures: The above test failure is on test-rackspace-win2012r2-x64-3.

@Trott
Copy link
Member

Trott commented Nov 19, 2018 •
edited by refack
Loading

CI stress test: https://ci.nodejs.org/job/node-stress-single-test/2086/ (Stress test is on test-rackspace-win2012r2-x64-12.) ✔️

@refack refack closed this as completed Nov 19, 2018
@refack
Copy link
Contributor Author

refack commented Nov 19, 2018

Stress did not repro.

@Trott
Copy link
Member

Trott commented Dec 15, 2018

Re-opening because it's shown up again.

https://ci.nodejs.org/job/node-test-binary-windows/22470/COMPILED_BY=vs2017-x86,RUNNER=win2012r2,RUN_SUBSET=1/console

test-rackspace-win2012r2-x64-7

14:05:51 not ok 536 parallel/test-worker-uncaught-exception
14:05:51   ---
14:05:51   duration_ms: 120.186
14:05:51   severity: fail
14:05:51   exitcode: 1
14:05:51   stack: |-
14:05:51     timeout
14:05:51     foo
14:05:51   ...

@Trott Trott reopened this Dec 15, 2018
@addaleax addaleax mentioned this issue Jan 31, 2019
Closed
addaleax added a commit to addaleax/node that referenced this issue Feb 3, 2019
@addaleax
worker,etw: only enable ETW on the main thread
b8624ab 
The Windows ETW code is not written to be compatible with multi-threading,
and in particular it relies on global state like a single static
`uv_async_t`. Adding that to multiple threads would corrupt the
corresponding loops' handle queues.

This addresses the flakiness of at least `test-worker-exit-code` and
very likely other flaky tests that relate to Worker threads on Windows as well.

Fixes: nodejs#25847
Fixes: nodejs#25702
Fixes: nodejs#24005
Fixes: nodejs#23873
@addaleax addaleax mentioned this issue Feb 3, 2019
Closed
2 tasks
addaleax added a commit that referenced this issue Feb 6, 2019
@addaleax
worker,etw: only enable ETW on the main thread
c959d60 
The Windows ETW code is not written to be compatible with multi
threading, and in particular it relies on global state like a
single static `uv_async_t`. Adding that to multiple threads
would corrupt the corresponding loops' handle queues.

This addresses the flakiness of at least
`test-worker-exit-code` and very likely other flaky tests that
relate to Worker threads on Windows as well.

Fixes: #25847
Fixes: #25702
Fixes: #24005
Fixes: #23873

PR-URL: #25907
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. test Issues and PRs related to the tests. windows Issues and PRs related to the Windows platform. worker Issues and PRs related to Worker support.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

worker,etw: only enable ETW on the main thread addaleax/node
2 participants
@refack @Trott