Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

node 10.7.0 fails to build - error in traced_value.cc #21903

Closed
kzalewski opened this issue Jul 20, 2018 · 5 comments
Closed

node 10.7.0 fails to build - error in traced_value.cc #21903

kzalewski opened this issue Jul 20, 2018 · 5 comments
Assignees
@addaleax
Labels
build Issues and PRs related to build files or the CI.

Comments

@kzalewski
Copy link

  • Version: v10.7.0
  • Platform: Linux 4.14.55 x86_64
  • Subsystem:

Building node 10.7.0 fails when compiling src/tracing/traced_value.cc with the following error:

../src/tracing/traced_value.cc:22:30: error: '__builtin_fpclassify' is not a member of 'std'
 #define FPCLASSIFY_NAMESPACE std

Adding
#include <cmath>
to the list of include files in traced_value.cc solves the compilation problem.
@ChALkeR ChALkeR added the build Issues and PRs related to build files or the CI. label Jul 20, 2018
@ChALkeR
Copy link
Member

ChALkeR commented Jul 20, 2018

@kzalewski What complier (and which version) are you using?

@kzalewski
Copy link
Author

The compiler is GCC.
Version is 5.5.0.

@ChALkeR
Copy link
Member

ChALkeR commented Jul 20, 2018 •
edited
Loading

That falls under supported versions as listed in BUILDING.md.

/cc @nodejs/build, I believe this has a patch attached in the issue.

@addaleax addaleax self-assigned this Jul 21, 2018
addaleax added a commit to addaleax/node that referenced this issue Jul 21, 2018
@addaleax
src: add missing cmath include to traced_value.cc
a3ee8fa 
Fixes: nodejs#21903
@addaleax addaleax mentioned this issue Jul 21, 2018
Closed
2 tasks
@jasnell
Copy link
Member

jasnell commented Jul 23, 2018

Sigh... we really need to make sure CI has full coverage for all of the compiler version combinations we use.

@gibfahn
Copy link
Member

gibfahn commented Jul 23, 2018

Sigh... we really need to make sure CI has full coverage for all of the compiler version combinations we use.

That would be nice, but given the range I'm not sure we'll be able to. @nodejs/build maybe one of each major gcc release at least would be good (or maybe there's a way to work out what releases builders are most likely to have).

GCC 8.1
GCC 7.3
GCC 7.2
GCC 7.1
GCC 6.4
GCC 6.3
GCC 6.2
GCC 6.1
GCC 5.5
GCC 5.4
GCC 5.3
GCC 5.2
GCC 5.1
GCC 4.9.4

targos pushed a commit that referenced this issue Jul 26, 2018
@addaleax @targos
src: add missing cmath include to traced_value.cc
f6606bf 
Fixes: #21903

PR-URL: #21924
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
This was referenced Jun 18, 2021
Open
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@addaleax addaleax

Labels
build Issues and PRs related to build files or the CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

src: add missing cmath include to traced_value.cc addaleax/node
5 participants
@kzalewski @ChALkeR @jasnell @addaleax @gibfahn