Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nominating jdalton as collaborator #20828

Closed
benjamingr opened this issue May 18, 2018 · 14 comments
Closed

Nominating jdalton as collaborator #20828

benjamingr opened this issue May 18, 2018 · 14 comments
Labels
meta Issues and PRs related to the general management of the project.

Comments

@benjamingr
Copy link
Member

benjamingr commented May 18, 2018 •
edited
Loading

Hi all,

I'd like to nominate @jdalton to be a collaborator. JDD has been very active in the modules team and very open to feedback. He wrote some popular packages and brings in a lot of insight. I believe he would make a valuable addition to the collaborator team

Commits in the nodejs/node repository
Pull requests in the nodejs/node repository
Comments and reviews on issues and pull requests in the nodejs/node repository.
@MylesBorins
Copy link
Contributor

+1 🎉🎉🎉

@targos
Copy link
Member

targos commented May 18, 2018

+1 !

@BridgeAR
Copy link
Member

+1!

@BridgeAR BridgeAR added the meta Issues and PRs related to the general management of the project. label May 19, 2018
@mhdawson
Copy link
Member

+1

@benjamingr benjamingr added the tsc-agenda Issues and PRs to discuss during the meetings of the TSC. label May 20, 2018
@mhdawson mhdawson mentioned this issue May 21, 2018
Closed
@jdalton
Copy link
Member

jdalton commented May 23, 2018 •
edited
Loading

Thanks for nomination. I'm totally up for becoming a core collaborator! ❤️

@benjamingr
Copy link
Member Author

This was discussed at the TSC meeting yesterday - congradulations @jdalton !

can someone from @nodejs/tsc confirm, remove the TSC agenda label and help with onboarding?

@mcollina
Copy link
Member

Welcome @jdalton! Confirmed.

@jdalton
Copy link
Member

jdalton commented May 24, 2018

Wahoo! Let me know the onboarding bits and I'll get to it 🎉 🎈 🎊

@benjamingr
Copy link
Member Author

Ping @nodejs/onboarding

@Trott Trott removed the tsc-agenda Issues and PRs to discuss during the meetings of the TSC. label May 24, 2018
@jdalton
Copy link
Member

jdalton commented May 25, 2018

The @nodejs/onboarding group can ping me via email if needed too.

@jdalton jdalton mentioned this issue May 25, 2018
Closed
2 tasks
@Trott
Copy link
Member

Trott commented May 26, 2018

@jdalton If you're eager to get going, anyone on @nodejs/tsc can do the onboarding. (The people in @nodejs/onboarding are the ones who usually do it, but that's just because they volunteer for it more often than everyone else.)

@jdalton
Copy link
Member

jdalton commented May 26, 2018

Thanks @Trott!

At anyone's earliest convenience is fine. I know the three-day weekend is upon many of us. Feel free to send an email or twitter DM to coordinate times/calls/tasks/etc.

@mcollina
Copy link
Member

@jdalton in which timezone are you in? If you are in Europe I can help during Monday or Tuesday business hours.

@jdalton
Copy link
Member

jdalton commented May 26, 2018 •
edited
Loading

Thanks @mcollina!

I'm in the Redmond WA, USA area (Pacific Time; UTC -7).
@Trott has contacted me and has scheduled a time to onboard 😸

MylesBorins pushed a commit that referenced this issue May 29, 2018
@jdalton @MylesBorins
doc: add jdalton to collaborators
babc9da 
PR-URL: #20968
Fixes: #20828
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

doc: add jdalton to collaborators
8 participants
@jdalton @mcollina @MylesBorins @Trott @benjamingr @targos @BridgeAR @mhdawson