Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for resolving CAA records #19239

Closed
jfromaniello opened this issue Mar 8, 2018 · 4 comments
Closed

Add support for resolving CAA records #19239

jfromaniello opened this issue Mar 8, 2018 · 4 comments
Labels
dns Issues and PRs related to the dns subsystem.

Comments

@jfromaniello
Copy link
Contributor

This type of record is defined by rfc6844.

IANA has assigned Resource Record Type 257 for the CAA Resource
Record Type and added the line depicted below to the registry named
"Resource Record (RR) TYPEs" and QTYPEs as defined in BCP 42
[RFC6195] and located at
http://www.iana.org/assignments/dns-parameters.

  • Version: v8.6.0
  • Platform: all
  • Subsystem: dns
> dns.resolve('example.com', 'CAA', (err, recs) => console.log(recs))
Error: Unknown type "CAA"
    at Resolver.resolve (dns.js:316:11)
    at repl:1:5
    at ContextifyScript.Script.runInThisContext (vm.js:50:33)
    at REPLServer.defaultEval (repl.js:239:29)
    at bound (domain.js:301:14)
    at REPLServer.runBound [as eval] (domain.js:314:12)
    at REPLServer.onLine (repl.js:440:10)
    at emitOne (events.js:120:20)
    at REPLServer.emit (events.js:210:7)
    at REPLServer.Interface._onLine (readline.js:282:10)
@tniessen
Copy link
Member

tniessen commented Mar 8, 2018

Not sure whether c-ares supports CAA, probably something for #14713.

@tniessen tniessen added the dns Issues and PRs related to the dns subsystem. label Mar 8, 2018
@bnoordhuis
Copy link
Member

Not sure whether c-ares supports CAA

It doesn't.

@tniessen tniessen mentioned this issue Mar 9, 2018
Closed
8 tasks
@bnoordhuis
Copy link
Member

Continues in #14713.

@ad-m ad-m mentioned this issue Nov 20, 2019
Closed
lxdicted added a commit to lxdicted/node that referenced this issue Oct 2, 2020
@lxdicted
Added support for resolving DNS CAA records
08d2e88 
This adds support for DNS Certification Authority
Authorization (RFC 6844) to nodejs.

This closes nodejs#19239 and possibly affects nodejs#14713.
@lxdicted lxdicted mentioned this issue Oct 2, 2020
Closed
4 tasks
aduh95 pushed a commit that referenced this issue Oct 16, 2020
@lxdicted @aduh95
net: add support for resolving DNS CAA records
6f34498 
This adds support for DNS Certification Authority Authorization
(RFC 8659) to Node.js.

PR-URL: #35466
Fixes: #19239
Refs: #14713
Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos pushed a commit that referenced this issue May 1, 2021
@lxdicted @targos
net: add support for resolving DNS CAA records
fd08c37 
This adds support for DNS Certification Authority Authorization
(RFC 8659) to Node.js.

PR-URL: #35466
Fixes: #19239
Refs: #14713
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@coolaj86
Copy link
Contributor

coolaj86 commented Apr 29, 2022 •
edited
Loading

Has this been implemented in the https module? Or is that still vulnerable?

Must CAA checks must be done in a side channel / layered in a client library?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dns Issues and PRs related to the dns subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature/dns caa lxdicted/node
4 participants
@coolaj86 @jfromaniello @bnoordhuis @tniessen