-
Notifications
You must be signed in to change notification settings - Fork 30.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change "comma-dangle" rule #19131
Comments
There would be too much churn, I think. Also, off the top of my head I'm not even certain how far back V8 support for it goes. Would we be able to backport such a change to v6.x? |
Ok, if we can't use |
There's going to be churn either way. Long-term we would likely prefer Then again, if V6.x already supports trailing commas then if someone wanted to do that and immediately backport to all active release lines, I wouldn't personally stand in the way. |
@apapirovski v6 does not support trailing commas in function declarations and calls |
So, we can use this rule for objects and arrays only |
@apapirovski
How can I do this? |
- change the rule - fix all linting issues - close nodejs#19131
Not sure whether there is consensus about this, I myself am certainly not a fan of dangling commas and definitely not in favor of enforcing them. There are not too many situations where this rule actually reduces the diff size and it appears unnatural to me to end a list with a separator. |
I am going to close this issue due to the concerns in this PR #19133. Thank you for the discussion! |
What about changing this rule in eslint config? At the moment it's
only-multiline
which allows but does not require trailing commas, and it can create misunderstandings in code review process.Besides, changing this rule to
always-multiline
will allow us to avoid misunderstandings and make diffs cleanerThe text was updated successfully, but these errors were encountered: