Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

investigate flaky parallel/test-tls-server-verify on Windows #18269

Closed
Trott opened this issue Jan 20, 2018 · 5 comments
Closed

investigate flaky parallel/test-tls-server-verify on Windows #18269

Trott opened this issue Jan 20, 2018 · 5 comments
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. test Issues and PRs related to the tests. tls Issues and PRs related to the tls subsystem. windows Issues and PRs related to the Windows platform.

Comments

@Trott
Copy link
Member

Trott commented Jan 20, 2018

  • Version: 10.0.0-pre
  • Platform: win2016, vs2017
  • Subsystem: test

https://ci.nodejs.org/job/node-test-binary-windows/14353/COMPILED_BY=vs2017,RUNNER=win2016,RUN_SUBSET=3/console

not ok 410 parallel/test-tls-server-verify
  ---
  duration_ms: 120.355
  severity: fail
  stack: |-
    timeout
@Trott Trott added tls Issues and PRs related to the tls subsystem. windows Issues and PRs related to the Windows platform. test Issues and PRs related to the tests. flaky-test Issues and PRs related to the tests with unstable failures on the CI. labels Jan 20, 2018
@apapirovski
Copy link
Member

@addaleax I believe this only started occurring after the revert in ea7400c

@kfarnung kfarnung mentioned this issue Jan 23, 2018
Merged
2 tasks
@MylesBorins
Copy link
Contributor

This is starting to fail on 6.x
https://ci.nodejs.org/job/node-test-binary-windows/14430/COMPILED_BY=vs2015,RUNNER=win2016,RUN_SUBSET=3/console

not ok 294 parallel/test-tls-server-verify
  ---
  duration_ms: 60.346
  severity: fail
  stack: |-
    timeout
  ...

@MylesBorins
Copy link
Contributor

The two new commits landed on v6.x are

  • 809858c - crypto: expose ECDH class (7 days ago)
  • 6014d66 - crypto: add randomFill and randomFillSync (7 days ago)

@gibfahn
Copy link
Member

gibfahn commented Jan 24, 2018

Failing on v8.x as well.

@gibfahn gibfahn mentioned this issue Jan 24, 2018
Merged
@mmarchini mmarchini mentioned this issue Jan 25, 2018
Closed
2 tasks
Trott added a commit to Trott/io.js that referenced this issue Jan 26, 2018
@Trott
test: fix test/parallel/test-tls-server-verify.js on Windows CI
e3a4fd1 
The test runs two test cases at a time. This is not relevant to what the
test is actually testing. Not sure why doing it that way causes a
deadlock on some Windows servers, but running one at a time fixes it.

Fixes: nodejs#18269
@Trott Trott mentioned this issue Jan 26, 2018
Closed
2 tasks
@Trott
Copy link
Member Author

Trott commented Jan 26, 2018

Proposed fix in #18382

@Trott Trott closed this as completed in 1ecd2be Jan 26, 2018
evanlucas pushed a commit that referenced this issue Jan 30, 2018
@Trott @evanlucas
test: fix test-tls-server-verify.js on Windows CI
1458e51 
The test runs two test cases at a time. This is not relevant to what the
test is actually testing. Not sure why doing it that way causes a
deadlock on some Windows servers, but running one at a time fixes it.

Fixes: #18269

PR-URL: #18382
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this issue Feb 5, 2018
@Trott @MylesBorins
test: fix test-tls-server-verify.js on Windows CI
75fbd51 
The test runs two test cases at a time. This is not relevant to what the
test is actually testing. Not sure why doing it that way causes a
deadlock on some Windows servers, but running one at a time fixes it.

Fixes: #18269

PR-URL: #18382
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this issue Feb 7, 2018
@Trott @MylesBorins
test: fix test-tls-server-verify.js on Windows CI
51999d0 
The test runs two test cases at a time. This is not relevant to what the
test is actually testing. Not sure why doing it that way causes a
deadlock on some Windows servers, but running one at a time fixes it.

Fixes: #18269

PR-URL: #18382
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this issue Feb 11, 2018
@Trott @MylesBorins
test: fix test-tls-server-verify.js on Windows CI
79016c5 
The test runs two test cases at a time. This is not relevant to what the
test is actually testing. Not sure why doing it that way causes a
deadlock on some Windows servers, but running one at a time fixes it.

Fixes: #18269

PR-URL: #18382
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this issue Feb 12, 2018
@Trott @MylesBorins
test: fix test-tls-server-verify.js on Windows CI
94c0acb 
The test runs two test cases at a time. This is not relevant to what the
test is actually testing. Not sure why doing it that way causes a
deadlock on some Windows servers, but running one at a time fixes it.

Fixes: #18269

PR-URL: #18382
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this issue Feb 13, 2018
@Trott @MylesBorins
test: fix test-tls-server-verify.js on Windows CI
fce10f7 
The test runs two test cases at a time. This is not relevant to what the
test is actually testing. Not sure why doing it that way causes a
deadlock on some Windows servers, but running one at a time fixes it.

Fixes: #18269

PR-URL: #18382
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MayaLekova pushed a commit to MayaLekova/node that referenced this issue May 8, 2018
@Trott @MayaLekova
test: fix test-tls-server-verify.js on Windows CI
cc06f41 
The test runs two test cases at a time. This is not relevant to what the
test is actually testing. Not sure why doing it that way causes a
deadlock on some Windows servers, but running one at a time fixes it.

Fixes: nodejs#18269

PR-URL: nodejs#18382
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This was referenced Apr 6, 2024
Open
Open
Open
This was referenced Apr 7, 2024
Open
Open
This was referenced Apr 7, 2024
Open
Open
Open
Open
Open
This was referenced Apr 7, 2024
Open
Open
Open
Open
Open
@baby636 baby636 mentioned this issue Apr 7, 2024
Open
@ryan-ally ryan-ally mentioned this issue Apr 7, 2024
Open
This was referenced Apr 7, 2024
Open
Open
Open
Open
Open
@aliscco aliscco mentioned this issue Apr 7, 2024
Open
@leonardoadame leonardoadame mentioned this issue Apr 7, 2024
Open
This was referenced Apr 8, 2024
Open
Open
Open
@wedataintelligence wedataintelligence mentioned this issue Oct 9, 2024
Open
@ron-a20 ron-a20 mentioned this issue Oct 9, 2024
Open
@aliceUnhinged613 aliceUnhinged613 mentioned this issue Oct 11, 2024
Open
This was referenced Oct 21, 2024
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. test Issues and PRs related to the tests. tls Issues and PRs related to the tls subsystem. windows Issues and PRs related to the Windows platform.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: fix test/parallel/test-tls-server-verify.js on Windows CI Trott/io.js
4 participants
@apapirovski @MylesBorins @Trott @gibfahn