createWriteStream on Ubuntu not using default autoClose option

[rush1818]

• Version: v9.2.1 and v9.3.0
• Platform: Ubuntu 16.04

I am using createWriteStream in my code which throws the following error on Ubuntu:

events.js:180
    throw new errors.TypeError('ERR_INVALID_ARG_TYPE', 'listener', 'Function');
    ^

TypeError [ERR_INVALID_ARG_TYPE]: The "listener" argument must be of type Function

Adding the autoClose option solves this error. The docs mention that autoClose=true by default so not sure why I had to explicitly specify it again.

The code does not throw error when running on mac 10.12.6 with node 9.2.1 and 9.3.0.

The code works without any errors on Ubuntu 16.04 when using node 8.9.3. Looks like something changed after 8.9.3 for the Ubuntu build which is causing this issue.

[bnoordhuis]

How do you call it? Please post a standalone code example.

[rush1818]

Here you go:

const FS = require('fs');
const zlib = require('zlib');

const gzip = zlib.createGzip();
const inputStream = FS.createReadStream('./file.txt');
const outputStream = FS.createWriteStream('./output.gz');

outputStream.on('finish', function () {
  outputStream.close();
 // Perform other logic as well
});

inputStream.pipe(gzip).pipe(outputStream);

This code block did not work on my Mac as well. I am calling the close() method to close the writeStream. When I changed it to use destroy() instead it worked.

On Ubuntu, one of my team mate was able to solve the error by changing adding the {autoClose: true} option and leaving the close() as is.

Also, the project has been in service for 1+ years without errors so it could be that there are some API changes I missed when I upgraded node to v9.

[bnoordhuis]

Thanks. Just so we're on the same page, can you post the full stack trace that you got?

edit: that said, I suspect e5c290b is responsible for what you're seeing.

[timotew]

@bnoordhuis I try to reproduce the error, This is what i got on Ubuntu:

events.js:180
    throw new errors.TypeError('ERR_INVALID_ARG_TYPE', 'listener', 'Function');
    ^

TypeError [ERR_INVALID_ARG_TYPE]: The "listener" argument must be of type Function
    at _addListener (events.js:180:11)
    at WriteStream.addListener (events.js:240:10)
    at WriteStream.close (fs.js:2302:10)
    at WriteStream.<anonymous> (/home/timothy/nood/app.js:9:16)
    at WriteStream.emit (events.js:164:20)
    at finishMaybe (_stream_writable.js:605:14)
    at afterWrite (_stream_writable.js:456:3)
    at onwrite (_stream_writable.js:446:7)
    at fs.js:2246:5
    at FSReqWrap.wrapper [as oncomplete] (fs.js:703:5)

[bnoordhuis]

@timotew Thanks!

@mcollina Looks like e5c290b#diff-9a205ef7ee967ee32efee02e58b3482dR2275 needs an additional type check.

[mcollina]

@bnoordhuis yes indeed! I'll work on a fix tomorrow.

[rush1818]

I get the same error as @timotew . Thanks for identifying the cause!

[mcollina]

The fix will be released in 9.4.0.