Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

meta: commit messages with long URLs #17116

Closed
vsemozhetbyt opened this issue Nov 18, 2017 · 4 comments
Closed

meta: commit messages with long URLs #17116

vsemozhetbyt opened this issue Nov 18, 2017 · 4 comments
Labels
doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project.

Comments

@vsemozhetbyt
Copy link
Contributor

Should we alleviate the 72 characters rule for lines with long URLs and note about it in the COLLABORATOR_GUIDE.md?

Example: #17107

Refs: nodejs/core-validate-commit#24
@vsemozhetbyt vsemozhetbyt added doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project. labels Nov 18, 2017
@vsemozhetbyt vsemozhetbyt mentioned this issue Nov 18, 2017
Closed
@joyeecheung
Copy link
Member

I think there aren't really any workaround for this anyway? This is similar to the ignoreUrls option of max-length in eslint.

@vsemozhetbyt
Copy link
Contributor Author

@joyeecheung We can use some URL shortener, but this can mess things up.

@gibfahn
Copy link
Member

gibfahn commented Dec 28, 2017

Should we alleviate the 72 characters rule for lines with long URLs and note about it in the COLLABORATOR_GUIDE.md?

I think this is what we've always done anyway, so why not make it explicit.

@mhdawson
Copy link
Member

mhdawson commented Jan 3, 2018

+1 to what @gibfahn said.

@vsemozhetbyt vsemozhetbyt mentioned this issue Apr 22, 2018
Closed
3 tasks
jasnell pushed a commit that referenced this issue Apr 23, 2018
@vsemozhetbyt @jasnell
meta: document commit msg exception for long URLs
d591a59 
PR-URL: #20207
Fixes: #17116
Refs: nodejs/core-validate-commit#24
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@joyeecheung @mhdawson @vsemozhetbyt @gibfahn