util.promisify custom implementation of child_process.exec throws away stdout and stderr in case of error #13364
Labels
child_process
Issues and PRs related to the child_process subsystem.
promises
Issues and PRs related to ECMAScript promises.
util
Issues and PRs related to the built-in util module.
Comments
addaleax
added
child_process
That sounds reasonable to me, yup. |
4 tasks
addaleax
pushed a commit
that referenced
this issue
Jun 10, 2017
This converts the initial implementation of a promised exec that used the customPromisifyArgs support in util.promisify with a custom implementation. This is because exec and execFile, when there is an error, still supply the stdout and stderr of the process, and yet the promisified version with customPromisifyArgs does not supply this ability. I created a custom implementation and attached it to exec and execFile using the util.promisify.custom key. Fixes: #13364 PR-URL: #13388 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Wrapping
child_process.exec-s inutil.promisifyreturns a function that returns stdout and stderr in case there is no error (which is good), but does not return stdout and stderr in case of an error.This means that if the command fails (with exit code != 0) then we have no access to the stdout and stderr (well, we can access stderr in a hackish way through exc.toString(), but that's hackish and still stdout can't be reached).
I suggest attaching
stdoutandstderrproperties to the error returned by the rejected promise. If this is OK with everybody, I can fix it and create a pull request for this.The text was updated successfully, but these errors were encountered: