Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate flaky test-https-server-keep-alive-timeout #13307

Closed
Trott opened this issue May 30, 2017 · 5 comments
Closed

Investigate flaky test-https-server-keep-alive-timeout #13307

Trott opened this issue May 30, 2017 · 5 comments
Labels
https Issues or PRs related to the https subsystem. test Issues and PRs related to the tests.

Comments

@Trott
Copy link
Member

Trott commented May 30, 2017

  • Version: v8.0.0-pre
  • Platform: aix61
  • Subsystem: test, https

https://ci.nodejs.org/job/node-test-commit-aix/6219/nodes=aix61-ppc64/console

not ok 675 parallel/test-https-server-keep-alive-timeout
  ---
  duration_ms: 1.803
  severity: fail
  stack: |-
    events.js:182
          throw er; // Unhandled 'error' event
          ^
    
    Error: read ECONNRESET
        at exports._errnoException (util.js:1026:11)
        at TLSWrap.onread (net.js:607:25)
  ...
@Trott Trott added aix Issues and PRs related to the AIX platform. https Issues or PRs related to the https subsystem. test Issues and PRs related to the tests. labels May 30, 2017
@Trott
Copy link
Member Author

Trott commented May 30, 2017

1 second timer etc., test seems race-prone.

@Trott
Copy link
Member Author

Trott commented May 30, 2017

Easily replicated with tools/test.py -j 64 --repeat 128 test/parallel/test-https-server-keep-alive-timeout.js

Easiest solution is to move test to sequential but a refactor may help keep it in parallel.

@Trott
Copy link
Member Author

Trott commented May 30, 2017

Removing AIX from description as it's not AIX-specific.

@Trott Trott removed the aix Issues and PRs related to the AIX platform. label May 30, 2017
@Trott Trott changed the title Investigate flaky test-https-server-keep-alive-timeout on AIX Investigate flaky test-https-server-keep-alive-timeout May 30, 2017
@Trott Trott mentioned this issue May 30, 2017
Closed
2 tasks
@Trott
Copy link
Member Author

Trott commented May 30, 2017

Mitigation: #13312

@Trott
Copy link
Member Author

Trott commented Jun 1, 2017

Fail again in https://ci.nodejs.org/job/node-test-commit-aix/6249/nodes=aix61-ppc64/console.

Trott added a commit to Trott/io.js that referenced this issue Jun 1, 2017
@Trott
test: improve test-https-server-keep-alive-timeout
eedefc7 
The test is flaky under load. These changes greatly improve reliability.

* Use a recurring interval to determine when the test should end rather
  than a timer.
* Increase server timeout to 500ms to allow for events being delayed by
  system load

Changing to an interval has the added benefit of reducing the test run
time from over 2 seconds to under 1 second.

Fixes: nodejs#13307
@jasnell jasnell closed this as completed in ce5745b Jun 1, 2017
jasnell pushed a commit that referenced this issue Jun 5, 2017
@Trott @jasnell
test: improve test-https-server-keep-alive-timeout
e20f357 
The test is flaky under load. These changes greatly improve reliability.

* Use a recurring interval to determine when the test should end rather
  than a timer.
* Increase server timeout to 500ms to allow for events being delayed by
  system load

Changing to an interval has the added benefit of reducing the test run
time from over 2 seconds to under 1 second.

Fixes: #13307

PR-URL: #13312
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
https Issues or PRs related to the https subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: improve test-https-server-keep-alive-timeout Trott/io.js
1 participant
@Trott