Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: missing API links in process markdown #11717

Closed
mscdex opened this issue Mar 6, 2017 · 2 comments
Closed

doc: missing API links in process markdown #11717

mscdex opened this issue Mar 6, 2017 · 2 comments
Labels
doc Issues and PRs related to the documentations. good first issue Issues that are suitable for first-time contributors. process Issues and PRs related to the process subsystem.

Comments

@mscdex
Copy link
Contributor

mscdex commented Mar 6, 2017

  • Version: master, v7.7.0+
  • Platform: n/a
  • Subsystem: doc

The "A note on process I/O" section in the process.stdout description is missing link references at the bottom of the markdown for console.log() and console.error(), causing the links to not render correctly.
@mscdex mscdex added doc Issues and PRs related to the documentations. good first issue Issues that are suitable for first-time contributors. process Issues and PRs related to the process subsystem. labels Mar 6, 2017
@sam-github
Copy link
Contributor

I will fix.

@sam-github sam-github mentioned this issue Mar 6, 2017
Closed
2 tasks
sam-github added a commit to sam-github/node that referenced this issue Mar 7, 2017
@sam-github
doc: fix process links to console.log/error
79d7e19 
Fix: nodejs#11717
@fhinkel
Copy link
Member

fhinkel commented Mar 9, 2017

Thanks!

@fhinkel fhinkel closed this as completed Mar 9, 2017
fhinkel pushed a commit that referenced this issue Mar 9, 2017
@sam-github @fhinkel
doc: fix process links to console.log/error
28584db 
Fixes: #11717

PR-URL: #11718
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
italoacasas pushed a commit to italoacasas/node that referenced this issue Mar 13, 2017
@sam-github @italoacasas
doc: fix process links to console.log/error
517c3af 
Fixes: nodejs#11717

PR-URL: nodejs#11718
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
jungx098 pushed a commit to jungx098/node that referenced this issue Mar 21, 2017
@sam-github @jungx098
doc: fix process links to console.log/error
f69050f 
Fixes: nodejs#11717

PR-URL: nodejs#11718
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
MylesBorins pushed a commit that referenced this issue Apr 17, 2017
@sam-github @MylesBorins
doc: fix process links to console.log/error
bc116ab 
Fixes: #11717

PR-URL: #11718
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
MylesBorins pushed a commit that referenced this issue Apr 19, 2017
@sam-github @MylesBorins
doc: fix process links to console.log/error
8de856b 
Fixes: #11717

PR-URL: #11718
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
andrew749 pushed a commit to michielbaird/node that referenced this issue Jul 19, 2017
@sam-github @andrew749
doc: fix process links to console.log/error
76cb550 
Fixes: nodejs/node#11717

PR-URL: nodejs/node#11718
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. good first issue Issues that are suitable for first-time contributors. process Issues and PRs related to the process subsystem.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sam-github @mscdex @fhinkel