Skip to content

Commit

Permalink
doc: allow request for TSC reviews via the GitHub UI
Browse files Browse the repository at this point in the history
PR-URL: #56493
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
  • Loading branch information
aduh95 committed Jan 31, 2025
1 parent 08c26fd commit f62f370
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion doc/contributing/collaborator-guide.md
Original file line number Diff line number Diff line change
Expand Up @@ -523,7 +523,6 @@ deprecation level of an API.
Collaborators can opt to elevate pull requests or issues to the [TSC][].
Do this if a pull request or issue:

* Is labeled `semver-major`, or
* Has a significant impact on the codebase, or
* Is controversial, or
* Is at an impasse among collaborators who are participating in the discussion.
Expand All @@ -532,6 +531,9 @@ Do this if a pull request or issue:
[TSC][]. Do not use the GitHub UI on the right-hand side to assign to
`@nodejs/tsc` or request a review from `@nodejs/tsc`.

If a pull request is labeled `semver-major`, you can request a review from the
`@nodejs/tsc` GitHub team.

The TSC serves as the final arbiter where required.

## Landing pull requests
Expand Down

0 comments on commit f62f370

Please sign in to comment.