fixup! tools: add GitHub Action linter for pr-url

nodejs · Feb 5, 2021 · f445dfd · f445dfd
1 parent 5a19fd4
commit f445dfd
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 52 deletions.
diff --git a/test/parallel/test-fs-rmdir-recursive-sync-warns-not-found.js b/test/parallel/test-fs-rmdir-recursive-sync-warns-not-found.js
diff --git a/test/parallel/test-fs-rmdir-recursive-sync-warns-on-file.js b/test/parallel/test-fs-rmdir-recursive-sync-warns-on-file.js
diff --git a/...est-fs-rmdir-recursive-warns-not-found.js → ...st-fs-rmdir-recursive-throws-not-found.js b/...est-fs-rmdir-recursive-warns-not-found.js → ...st-fs-rmdir-recursive-throws-not-found.js
@@ -21,9 +21,7 @@ tmpdir.refresh();
     path.join(tmpdir.path, 'noexist.txt'),
     { recursive: true },
     common.mustCall((err) => {
-      assert.throws(() => { throw err; }, {
-        code: 'ENOENT',
-      });
+      assert.strictEqual(err.code, 'ENOENT');
     })
   );
 }

diff --git a/.../test-fs-rmdir-recursive-warns-on-file.js → ...test-fs-rmdir-recursive-throws-on-file.js b/.../test-fs-rmdir-recursive-warns-on-file.js → ...test-fs-rmdir-recursive-throws-on-file.js
@@ -18,9 +18,7 @@ tmpdir.refresh();
   const filePath = path.join(tmpdir.path, 'rmdir-recursive.txt');
   fs.writeFileSync(filePath, '');
   fs.rmdir(filePath, { recursive: true }, common.mustCall((err) => {
-    assert.throws(() => { throw err; }, {
-      code: 'ENOTDIR',
-    });
+    assert.strictEqual(err.code, 'ENOTDIR');
   }));
 }
 {

diff --git a/test/parallel/test-fs-rmdir-recursive.js b/test/parallel/test-fs-rmdir-recursive.js
@@ -73,8 +73,9 @@ function removeAsync(dir) {
 
       // Recursive removal should succeed.
       fs.rmdir(dir, { recursive: true }, common.mustSucceed(() => {
-        // No error should occur if recursive and the directory does not exist.
-        fs.rmdir(dir, { recursive: true }, common.mustSucceed(() => {
+        // An error should occur if recursive and the directory does not exist.
+        fs.rmdir(dir, { recursive: true }, common.mustCall((err) => {
+          assert.strictEqual(err.code, 'ENOENT');
           // Attempted removal should fail now because the directory is gone.
           fs.rmdir(dir, common.mustCall((err) => {
             assert.strictEqual(err.syscall, 'rmdir');
@@ -119,8 +120,9 @@ function removeAsync(dir) {
   // Recursive removal should succeed.
   fs.rmdirSync(dir, { recursive: true });
 
-  // No error should occur if recursive and the directory does not exist.
-  fs.rmdirSync(dir, { recursive: true });
+  // An error should occur if recursive and the directory does not exist.
+  assert.throws(() => fs.rmdirSync(dir, { recursive: true }),
+                { code: 'ENOENT' });
 
   // Attempted removal should fail now because the directory is gone.
   assert.throws(() => fs.rmdirSync(dir), { syscall: 'rmdir' });
@@ -140,8 +142,9 @@ function removeAsync(dir) {
   // Recursive removal should succeed.
   await fs.promises.rmdir(dir, { recursive: true });
 
-  // No error should occur if recursive and the directory does not exist.
-  await fs.promises.rmdir(dir, { recursive: true });
+  // An error should occur if recursive and the directory does not exist.
+  await assert.rejects(fs.promises.rmdir(dir, { recursive: true }),
+                       { code: 'ENOENT' });
 
   // Attempted removal should fail now because the directory is gone.
   assert.rejects(fs.promises.rmdir(dir), { syscall: 'rmdir' });