Skip to content

Commit

Permalink
doc: document breaking change in http.IncomingMessage 'close' event
Browse files Browse the repository at this point in the history
PR-URL: #42521
Fixes: #38924
Refs: #33035
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
  • Loading branch information
ShogunPanda authored and juanarbol committed May 31, 2022
1 parent f83fc62 commit f2dc7c8
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 1 deletion.
7 changes: 6 additions & 1 deletion doc/api/http.md
Original file line number Diff line number Diff line change
Expand Up @@ -2102,9 +2102,14 @@ Emitted when the request has been aborted.

<!-- YAML
added: v0.4.2
changes:
- version: v16.0.0
pr-url: https://github.com/nodejs/node/pull/33035
description: The close event is now emitted when the request has been completed and not when the
underlying socket is closed.
-->

Indicates that the underlying connection was closed.
Emitted when the request has been completed.

### `message.aborted`

Expand Down
1 change: 1 addition & 0 deletions doc/changelogs/CHANGELOG_V16.md
Original file line number Diff line number Diff line change
Expand Up @@ -2745,6 +2745,7 @@ Contributed by Michaël Zasso - [#37587](https://github.com/nodejs/node/pull/375
* **deps**: update llhttp to 6.0.0 (Fedor Indutny) [#38277](https://github.com/nodejs/node/pull/38277)
* **deps**: upgrade npm to 7.10.0 (Ruy Adorno) [#38254](https://github.com/nodejs/node/pull/38254)
* **(SEMVER-MINOR)** **http**: add http.ClientRequest.getRawHeaderNames() (simov) [#37660](https://github.com/nodejs/node/pull/37660)
* **(SEMVER-MAJOR)** **http**: use `autoDestroy: true` in incoming message (Daniele Belardi) [#33035](https://github.com/nodejs/node/pull/33035)
* **(SEMVER-MAJOR)** **lib,src**: update cluster to use Parent (Michael Dawson) [#36478](https://github.com/nodejs/node/pull/36478)
* **(SEMVER-MINOR)** **module**: add support for `node:`‑prefixed `require(…)` calls (ExE Boss) [#37246](https://github.com/nodejs/node/pull/37246)
* **(SEMVER-MINOR)** **perf\_hooks**: add histogram option to timerify (James M Snell) [#37475](https://github.com/nodejs/node/pull/37475)
Expand Down

0 comments on commit f2dc7c8

Please sign in to comment.