Skip to content

Commit

Permalink
src: remove unused Connection::ClearError()
Browse files Browse the repository at this point in the history
PR-URL: #14514
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jason Ginchereau <jasongin@microsoft.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Tobias Nie�en <tniessen@tnie.de>
  • Loading branch information
bnoordhuis authored and addaleax committed Aug 7, 2017
1 parent 4b01d8c commit eb068a0
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 13 deletions.
12 changes: 0 additions & 12 deletions src/node_crypto.cc
Original file line number Diff line number Diff line change
Expand Up @@ -2699,18 +2699,6 @@ int Connection::HandleSSLError(const char* func,
}


void Connection::ClearError() {
#ifndef NDEBUG
HandleScope scope(ssl_env()->isolate());

// We should clear the error in JS-land
Local<String> error_key = ssl_env()->error_string();
Local<Value> error = object()->Get(error_key);
CHECK_EQ(error->BooleanValue(), false);
#endif // NDEBUG
}


void Connection::SetShutdownFlags() {
HandleScope scope(ssl_env()->isolate());

Expand Down
1 change: 0 additions & 1 deletion src/node_crypto.h
Original file line number Diff line number Diff line change
Expand Up @@ -390,7 +390,6 @@ class Connection : public AsyncWrap, public SSLWrap<Connection> {

int HandleSSLError(const char* func, int rv, ZeroStatus zs, SyscallStatus ss);

void ClearError();
void SetShutdownFlags();

Connection(Environment* env,
Expand Down

0 comments on commit eb068a0

Please sign in to comment.