url: remove javascript URL special case

Fixes: #11485 PR-URL: #12331 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
nodejs · Apr 12, 2017 · eb0492d · eb0492d
1 parent 2ced07c
commit eb0492d
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 10 deletions.
diff --git a/lib/internal/url.js b/lib/internal/url.js
@@ -556,8 +556,6 @@ Object.defineProperties(URL.prototype, {
       const ctx = this[context];
       // toUSVString is not needed.
       hash = `${hash}`;
-      if (this.protocol === 'javascript:')
-        return;
       if (!hash) {
         ctx.fragment = null;
         ctx.flags &= ~binding.URL_FLAGS_HAS_FRAGMENT;

diff --git a/test/fixtures/url-setter-tests.js b/test/fixtures/url-setter-tests.js
@@ -1800,13 +1800,13 @@ module.exports =
                 "hash": "#%c3%89t%C3%A9"
             }
         },
-        // {
-        //     "href": "javascript:alert(1)",
-        //     "new_value": "castle",
-        //     "expected": {
-        //         "href": "javascript:alert(1)#castle",
-        //         "hash": "#castle"
-        //     }
-        // }
+        {
+            "href": "javascript:alert(1)",
+            "new_value": "castle",
+            "expected": {
+                "href": "javascript:alert(1)#castle",
+                "hash": "#castle"
+            }
+        }
     ]
 }