Skip to content

Commit

Permalink
test: skip test-child-process-stdio-reuse-readable-stdio on Windows
Browse files Browse the repository at this point in the history
It is flaky due to the same cause of test-child-process-pipe-dataflow
being flaky - cygwin quirks - so skip it on Windows too.

Drive-by: remove the skip mark of test-child-process-pipe-dataflow
in the status file and directly skip it in the test with a comment.

PR-URL: #49621
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
  • Loading branch information
joyeecheung authored Sep 14, 2023
1 parent ba28cd8 commit dac5f29
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 3 deletions.
3 changes: 0 additions & 3 deletions test/parallel/parallel.status
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,6 @@ prefix parallel
test-crypto-keygen: PASS,FLAKY
# https://github.com/nodejs/node/issues/41201
test-fs-rmdir-recursive: PASS, FLAKY
# https://github.com/nodejs/node/issues/48300
test-child-process-pipe-dataflow: SKIP
test-child-process-stdio-reuse-readable-stdio: PASS, FLAKY

# Windows on ARM
[$system==win32 && $arch==arm64]
Expand Down
6 changes: 6 additions & 0 deletions test/parallel/test-child-process-pipe-dataflow.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
'use strict';
const common = require('../common');

if (common.isWindows) {
// https://github.com/nodejs/node/issues/48300
common.skip('Does not work with cygwin quirks on Windows');
}

const assert = require('assert');
const fs = require('fs');
const spawn = require('child_process').spawn;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
'use strict';
const common = require('../common');

if (common.isWindows) {
// https://github.com/nodejs/node/issues/48300
common.skip('Does not work with cygwin quirks on Windows');
}

const assert = require('assert');
const { spawn } = require('child_process');

Expand Down

0 comments on commit dac5f29

Please sign in to comment.