Skip to content

Commit

Permalink
test: unset NODE_OPTIONS for cctest
Browse files Browse the repository at this point in the history
The test may fail otherwise because of behaviour changes caused
by setting the environment variable.

Fixes: #31585

PR-URL: #31594
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
  • Loading branch information
addaleax authored and jasnell committed Feb 3, 2020
1 parent d4660ab commit d435dc4
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions test/cctest/node_test_fixture.h
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,7 @@ class NodeZeroIsolateTestFixture : public ::testing::Test {

static void SetUpTestCase() {
if (!node_initialized) {
uv_os_unsetenv("NODE_OPTIONS");
node_initialized = true;
int argc = 1;
const char* argv0 = "cctest";
Expand Down

0 comments on commit d435dc4

Please sign in to comment.