fixup! tools: fix bug in prefer-primordials ESLint rule

nodejs · Oct 27, 2021 · c73865c · c73865c
1 parent 899670a
commit c73865c
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/test/parallel/test-eslint-prefer-primordials.js b/test/parallel/test-eslint-prefer-primordials.js
@@ -81,6 +81,14 @@ new RuleTester({
         code: 'const { Map } = primordials; new Map()',
         options: [{ name: 'Map', into: 'Safe' }],
       },
+      {
+        code: `
+          const { Function } = primordials;
+          const rename = Function;
+          const obj = { rename };
+        `,
+        options: [{ name: 'Function' }],
+      },
     ],
     invalid: [
       {

diff --git a/tools/eslint-rules/prefer-primordials.js b/tools/eslint-rules/prefer-primordials.js
@@ -106,7 +106,8 @@ module.exports = {
         const defs = globalScope.set.get(name)?.defs;
         if (parentName && isTarget(nameMap, parentName)) {
           if (defs?.[0].name.name !== 'primordials' &&
-              !reported.has(parent.range[0])) {
+              !reported.has(parent.range[0]) &&
+              parent.parent?.id?.type !== 'Identifier') {
             reported.add(node.range[0]);
             const into = renameMap.get(name);
             context.report({