process: unhandledRejection support more errors

Support cross realm errors where `instanceof` errors in our unhandledRejection warning to print better error with stack traces.
nodejs · Jan 24, 2022 · c5093df · c5093df
1 parent ce41395
commit c5093df
Showing 1 changed file with 10 additions and 2 deletions.
diff --git a/lib/internal/process/promises.js b/lib/internal/process/promises.js
@@ -5,6 +5,7 @@ const {
   ArrayPrototypeShift,
   Error,
   ObjectDefineProperty,
+  ObjectHasOwn,
   SafeWeakMap,
 } = primordials;
 
@@ -179,14 +180,21 @@ function emitUnhandledRejectionWarning(uid, reason) {
       `(rejection id: ${uid})`
   );
   try {
-    if (reason instanceof Error) {
+    if (ObjectHasOwn(reason, 'stack')) {
       warning.stack = reason.stack;
       process.emitWarning(reason.stack, unhandledRejectionErrName);
     } else {
       process.emitWarning(
         noSideEffectsToString(reason), unhandledRejectionErrName);
     }
-  } catch {}
+  } catch {
+    try {
+      process.emitWarning(
+        noSideEffectsToString(reason), unhandledRejectionErrName);
+    } catch {
+      // Ignore.
+    }
+  }
 
   process.emitWarning(warning);
 }