-
Notifications
You must be signed in to change notification settings - Fork 30.4k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
When `timers.refresh()` is called inside a callback, the timer would incorrectly end up unrefed and thus not keep the event loop alive.
- Loading branch information
1 parent
cd9898a
commit c37a50a
Showing
2 changed files
with
17 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
// Flags: --expose-internals | ||
|
||
'use strict'; | ||
|
||
const common = require('../common'); | ||
|
||
// This test checks whether a refresh called inside the callback will keep | ||
// the event loop alive to run the timer again. | ||
|
||
let didCall = false; | ||
const timer = setTimeout(common.mustCall(() => { | ||
if (!didCall) { | ||
didCall = true; | ||
timer.refresh(); | ||
} | ||
}, 2), 1); |