Skip to content

Commit

Permalink
test: check and fail inspector-cluster-port-clash
Browse files Browse the repository at this point in the history
Currently this test fail when configured --without-inspector or
--without-ssl as it is expected to fail but the skipIfInspectorDisabled
check will exit as if the test was sucessful.

This commit checks if inspector support is available and fails the test
allowing the test to be skipped.

PR-URL: #14074
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
  • Loading branch information
danbev authored and addaleax committed Jul 11, 2017
1 parent 48843bd commit c2c242f
Showing 1 changed file with 9 additions and 2 deletions.
11 changes: 9 additions & 2 deletions test/known_issues/test-inspector-cluster-port-clash.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
// Flags: --inspect=0
'use strict';
const common = require('../common');
const assert = require('assert');

// With the current behavior of Node.js (at least as late as 8.1.0), this
// test fails with the following error:
Expand All @@ -10,9 +11,15 @@ const common = require('../common');
//
// Refs: https://github.com/nodejs/node/issues/13343

common.skipIfInspectorDisabled();
// This following check should be replaced by common.skipIfInspectorDisabled()
// if moved out of the known_issues directory.
if (process.config.variables.v8_enable_inspector === 0) {
// When the V8 inspector is disabled, using either --without-inspector or
// --without-ssl, this test will not fail which it is expected to do.
// The following fail will allow this test to be skipped by failing it.
assert.fail('skipping as V8 inspector is disabled');
}

const assert = require('assert');
const cluster = require('cluster');
const net = require('net');

Expand Down

0 comments on commit c2c242f

Please sign in to comment.