esm: fix import.meta.resolve crash

nodejs · Nov 8, 2024 · b8cb866 · b8cb866
1 parent 6af5c4e
commit b8cb866
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 2 deletions.
diff --git a/src/node_modules.cc b/src/node_modules.cc
@@ -412,7 +412,10 @@ void BindingData::GetPackageScopeConfig(
     }
 
     auto file_url = url::FileURLToPath(realm->env(), *package_json_url);
-    CHECK(file_url);
+    if (!file_url) {
+      url::ThrowInvalidURL(realm->env(), resolved.ToStringView(), std::nullopt);
+      return;
+    }
     error_context.specifier = resolved.ToString();
     auto package_json = GetPackageJSON(realm, *file_url, &error_context);
     if (package_json != nullptr) {

diff --git a/test/es-module/test-esm-import-meta-resolve.mjs b/test/es-module/test-esm-import-meta-resolve.mjs
@@ -1,6 +1,6 @@
 // Flags: --experimental-import-meta-resolve
 import { spawnPromisified } from '../common/index.mjs';
-import { fileURL as fixturesFileURL } from '../common/fixtures.mjs';
+import { fileURL as fixturesFileURL, path } from '../common/fixtures.mjs';
 import assert from 'assert';
 import { spawn } from 'child_process';
 import { execPath } from 'process';
@@ -106,3 +106,14 @@ await assert.rejects(import('data:text/javascript,export default import.meta.res
     stdout: 'http://example.com/\n',
   });
 }
+
+{
+  const result = await spawnPromisified(execPath, [
+    '--no-warnings',
+    '--experimental-import-meta-resolve',
+    path('import-meta-resolve-loader.js'),
+  ]);
+  assert.match(result.stderr, /ERR_INVALID_URL/);
+  assert.strictEqual(result.stdout, '');
+  assert.strictEqual(result.code, 1);
+}
diff --git a/test/fixtures/import-meta-resolve-loader.js b/test/fixtures/import-meta-resolve-loader.js
@@ -0,0 +1 @@
+import.meta.resolve('foo', 'http://example.com/bar.js');
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		import.meta.resolve('foo', 'http://example.com/bar.js');