Skip to content

Commit

Permalink
doc: require CI status indicator in PRs
Browse files Browse the repository at this point in the history
Commits are often landed despite failing on one or more CI platforms.
Having a CI status indicator in the PR should make this less likely to
happen.

PR-URL: #17151
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
  • Loading branch information
seishun authored and joyeecheung committed Dec 23, 2017
1 parent 79261f3 commit ae2bed9
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions COLLABORATOR_GUIDE.md
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,7 @@ test should *fail* before the change, and *pass* after the change.
All pull requests that modify executable code should be subjected to
continuous integration tests on the
[project CI server](https://ci.nodejs.org/).
The pull request should have a CI status indicator if possible.

#### Useful CI Jobs

Expand Down

0 comments on commit ae2bed9

Please sign in to comment.