console: make groupIndent non-enumerable

Hide the internal `groupIndent` key a bit by making it non-enumerable and non-configurable.
nodejs · Aug 24, 2017 · 9df027b · 9df027b
1 parent 483dec7
commit 9df027b
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 0 deletions.
diff --git a/lib/console.js b/lib/console.js
@@ -60,6 +60,8 @@ function Console(stdout, stderr, ignoreErrors = true) {
   Object.defineProperty(this, '_stderrErrorHandler', prop);
 
   this[kCounts] = new Map();
+
+  Object.defineProperty(this, kGroupIndent, { writable: true });
   this[kGroupIndent] = '';
 
   // bind the prototype functions to this Console instance

diff --git a/test/parallel/test-console-group.js b/test/parallel/test-console-group.js
@@ -136,3 +136,12 @@ function teardown() {
   assert.strictEqual(stderr, expectedErr);
   teardown();
 }
+
+// Check that the kGroupIndent symbol property is not enumerable
+{
+  const keys = Reflect.ownKeys(console)
+                      .filter((val) => console.propertyIsEnumerable(val))
+                      .map((val) => val.toString());
+  assert(!keys.includes('Symbol(groupIndent)'),
+         'groupIndent should not be enumerable');
+}