Skip to content

Commit

Permalink
fs: move method definition from header
Browse files Browse the repository at this point in the history
We are defining the definition of function in the header file itself. It
should be defined in the source file instead of the header file.

PR-URL: #36256
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
  • Loading branch information
yashLadha authored and Trott committed Nov 29, 2020
1 parent 6ca7312 commit 9bf12df
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
3 changes: 3 additions & 0 deletions src/node_file.cc
Original file line number Diff line number Diff line change
Expand Up @@ -2534,6 +2534,9 @@ void Initialize(Local<Object> target,
use_promises_symbol).Check();
}

BindingData* FSReqBase::binding_data() {
return binding_data_.get();
}
} // namespace fs

} // end namespace node
Expand Down
2 changes: 1 addition & 1 deletion src/node_file.h
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ class FSReqBase : public ReqWrap<uv_fs_t> {

void MemoryInfo(MemoryTracker* tracker) const override;

BindingData* binding_data() { return binding_data_.get(); }
BindingData* binding_data();

private:
std::unique_ptr<FSContinuationData> continuation_data_;
Expand Down

0 comments on commit 9bf12df

Please sign in to comment.