crypto: reduce range of size to int max

Refs: #38090 PR-URL: #38096 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
nodejs · Apr 12, 2021 · 993ed19 · 993ed19
1 parent 8dd0685
commit 993ed19
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/lib/internal/crypto/random.js b/lib/internal/crypto/random.js
@@ -57,8 +57,8 @@ const {
 
 const { FastBuffer } = require('internal/buffer');
 
-const kMaxUint32 = 2 ** 32 - 1;
-const kMaxPossibleLength = MathMin(kMaxLength, kMaxUint32);
+const kMaxInt32 = 2 ** 31 - 1;
+const kMaxPossibleLength = MathMin(kMaxLength, kMaxInt32);
 
 function assertOffset(offset, elementSize, length) {
   validateNumber(offset, 'offset');

diff --git a/test/parallel/test-crypto-random.js b/test/parallel/test-crypto-random.js
@@ -32,8 +32,8 @@ const cryptop = require('crypto').webcrypto;
 const { kMaxLength } = require('buffer');
 const { inspect } = require('util');
 
-const kMaxUint32 = Math.pow(2, 32) - 1;
-const kMaxPossibleLength = Math.min(kMaxLength, kMaxUint32);
+const kMaxInt32 = 2 ** 31 - 1;
+const kMaxPossibleLength = Math.min(kMaxLength, kMaxInt32);
 
 common.expectWarning('DeprecationWarning',
                      'crypto.pseudoRandomBytes is deprecated.', 'DEP0115');
@@ -51,7 +51,7 @@ common.expectWarning('DeprecationWarning',
       assert.throws(() => f(value, common.mustNotCall()), errObj);
     });
 
-    [-1, NaN, 2 ** 32].forEach((value) => {
+    [-1, NaN, 2 ** 32, 2 ** 31].forEach((value) => {
       const errObj = {
         code: 'ERR_OUT_OF_RANGE',
         name: 'RangeError',