Skip to content

Commit

Permalink
[Squash] Update test todo comment
Browse files Browse the repository at this point in the history
  • Loading branch information
jasnell committed Nov 21, 2017
1 parent 27cebcc commit 991b61c
Showing 1 changed file with 4 additions and 9 deletions.
13 changes: 4 additions & 9 deletions test/parallel/test-http2-too-many-streams.js
Original file line number Diff line number Diff line change
Expand Up @@ -53,15 +53,10 @@ server.listen(0, common.mustCall(() => {
{
const req = client.request();
req.resume();
// TODO(jasnell): Still investigating precisely why, but on Windows,
// the error is not emitted because the underlying
// mechanism ensures that only one request is sent
// at a time per the maxConcurrentStreams setting.
// This likely has to do with the way the response
// is being handled on the server side. This is safe
// to ignore on Windows because of the assert.strictEqual
// check in the on('stream') handler which ensures that
// only one request is being handled at any given time.
// TODO(jasnell): On Windows, the error is not emitted because the
// underlying mechanism ensures that only one request is sent at a time
// per the maxConcurrentStreams setting. Need to investigate why the
// same is not happening on posix systems.
if (!common.isWindows) {
req.on('error', common.expectsError({
code: 'ERR_HTTP2_STREAM_ERROR',
Expand Down

0 comments on commit 991b61c

Please sign in to comment.