fixup! fs: remove permissive rmdir recursive

nodejs · Mar 19, 2021 · 8e1e85e · 8e1e85e
1 parent d45a98b
commit 8e1e85e
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/test/parallel/test-fs-rmdir-recursive-sync-warns-on-file.js b/test/parallel/test-fs-rmdir-recursive-sync-warns-on-file.js
@@ -8,7 +8,6 @@ const path = require('path');
 tmpdir.refresh();
 
 {
-  // Should warn when trying to delete a file
   common.expectWarning(
     'DeprecationWarning',
     'In future versions of Node.js, fs.rmdir(path, { recursive: true }) ' +
@@ -19,6 +18,6 @@ tmpdir.refresh();
   fs.writeFileSync(filePath, '');
   assert.throws(
     () => fs.rmdirSync(filePath, { recursive: true }),
-    { code: 'ENOTDIR' }
+    { code: common.isWindows ? 'ENOENT' : 'ENOTDIR' }
   );
 }
diff --git a/test/parallel/test-fs-rmdir-recursive-warns-on-file.js b/test/parallel/test-fs-rmdir-recursive-warns-on-file.js
@@ -8,7 +8,6 @@ const path = require('path');
 tmpdir.refresh();
 
 {
-  // Should warn when trying to delete a file
   common.expectWarning(
     'DeprecationWarning',
     'In future versions of Node.js, fs.rmdir(path, { recursive: true }) ' +
@@ -18,6 +17,6 @@ tmpdir.refresh();
   const filePath = path.join(tmpdir.path, 'rmdir-recursive.txt');
   fs.writeFileSync(filePath, '');
   fs.rmdir(filePath, { recursive: true }, common.mustCall((err) => {
-    assert.strictEqual(err.code, 'ENOTDIR');
+    assert.strictEqual(err.code, common.isWindows ? 'ENOENT' : 'ENOTDIR');
   }));
 }