Skip to content

Commit

Permalink
util: fix wrong usage of Error.prepareStackTrace
Browse files Browse the repository at this point in the history
The return value of Error.prepareStackTrace will become the result
of Error.stack accesses. Setting Error.stack inside this callback
relies on the fact that the magic get accessor detects the change in
the middle of formatting, and is unnecessary in this instance.

Refs: v8#96
  • Loading branch information
szuend authored and addaleax committed Apr 16, 2019
1 parent 53e0f63 commit 8c0fcdc
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion lib/internal/util.js
Original file line number Diff line number Diff line change
Expand Up @@ -347,7 +347,7 @@ function isInsideNodeModules() {
// the perf implications should be okay.
getStructuredStack = runInNewContext(`(function() {
Error.prepareStackTrace = function(err, trace) {
err.stack = trace;
return trace;
};
Error.stackTraceLimit = Infinity;
Expand Down

0 comments on commit 8c0fcdc

Please sign in to comment.