Skip to content

Commit

Permalink
build: fix up build after v8 upgrade
Browse files Browse the repository at this point in the history
* Define and disable new flag `v8_use_external_startup_data`.

* Disable v8_postmortem_support, it's broken again.  Fedor (@indutny)
  has volunteered to fix it up in the near future.

PR-URL: #243
Reviewed-By: Fedor Indutny <fedor@indutny.com>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
  • Loading branch information
bnoordhuis committed Jan 7, 2015
1 parent dad73f6 commit 8a83eba
Showing 1 changed file with 6 additions and 3 deletions.
9 changes: 6 additions & 3 deletions common.gypi
Original file line number Diff line number Diff line change
Expand Up @@ -20,14 +20,17 @@
# Enable disassembler for `--print-code` v8 options
'v8_enable_disassembler': 1,

# Enable V8's post-mortem debugging only on unix flavors.
# Don't bake anything extra into the snapshot.
'v8_use_external_startup_data%': 0,

# Disable V8's post-mortem debugging; frequently broken and hardly used.
'v8_postmortem_support%': 'false',

'conditions': [
['OS == "win"', {
'os_posix': 0,
'v8_postmortem_support': 'false'
}, {
'os_posix': 1,
'v8_postmortem_support': 'true'
}],
['GENERATOR == "ninja" or OS== "mac"', {
'OBJ_DIR': '<(PRODUCT_DIR)/obj',
Expand Down

0 comments on commit 8a83eba

Please sign in to comment.