Skip to content

Commit

Permalink
Revert "test: mark test-cluster-bind-privileged-port flaky on arm"
Browse files Browse the repository at this point in the history
This reverts commit a45a404.

Solved by marking ports <1024 as privileged on Docker containers.

Ref: #36850
Ref: #36847
Ref: nodejs/build#2521

PR-URL: #36884
Refs: #36850
Refs: #36847
Refs: nodejs/build#2521
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Ash Cripps <acripps@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
  • Loading branch information
rvagg authored and ruyadorno committed Jan 21, 2021
1 parent f2ac4bb commit 8a82415
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions test/parallel/parallel.status
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,6 @@ test-async-hooks-http-parser-destroy: PASS,FLAKY
# https://github.com/nodejs/node/pull/31178
test-crypto-dh-stateless: SKIP
test-crypto-keygen: SKIP
# https://github.com/nodejs/node/issues/36847
test-cluster-bind-privileged-port: PASS,FLAKY
test-cluster-shared-handle-bind-privileged-port: PASS,FLAKY

[$system==solaris] # Also applies to SmartOS

Expand Down

0 comments on commit 8a82415

Please sign in to comment.