-
Notifications
You must be signed in to change notification settings - Fork 30.1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
console: avoid adding infinite error listeners
If the console destination is a unix pipe (net.Socket), write() is async. If the destination is broken, we are adding an 'error' event listener to avoid a process crash. This PR makes sure that we are adding that listener only once. Fixes: #16767
- Loading branch information
Showing
2 changed files
with
28 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
'use strict'; | ||
|
||
const common = require('../common'); | ||
const { Writable } = require('stream'); | ||
const { Console } = require('console'); | ||
const { EventEmitter } = require('events'); | ||
|
||
const stream = new Writable({ | ||
write(chunk, enc, cb) { | ||
cb(); | ||
}, | ||
writev(chunks, cb) { | ||
setTimeout(cb, 10, new Error('kaboom')); | ||
} | ||
}); | ||
const myConsole = new Console(stream, stream); | ||
|
||
process.on('warning', common.mustNotCall); | ||
|
||
stream.cork(); | ||
for (let i = 0; i < EventEmitter.defaultMaxListeners + 1; i++) { | ||
myConsole.log('a message'); | ||
} | ||
stream.uncork(); |