url: fix surrogate handling in encodeAuth()

nodejs · Feb 12, 2017 · 8368389 · 8368389
1 parent 4cafa60
commit 8368389
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/lib/internal/url.js b/lib/internal/url.js
@@ -577,6 +577,7 @@ function encodeAuth(str) {
     }
     // Surrogate pair
     ++i;
+    ++lastPos;
     var c2;
     if (i < str.length)
       c2 = str.charCodeAt(i) & 0x3FF;

diff --git a/test/parallel/test-url-format.js b/test/parallel/test-url-format.js
@@ -235,6 +235,15 @@ const formatTests = {
     protocol: 'file',
     pathname: '/home/user',
     path: '/home/user'
+  },
+
+  // surrogate in auth
+  'http://%F0%9F%98%80@www.example.com/': {
+    href: 'http://%F0%9F%98%80@www.example.com/',
+    protocol: 'http:',
+    auth: '\uD83D\uDE00',
+    hostname: 'www.example.com',
+    pathname: '/'
   }
 };
 for (const u in formatTests) {