Skip to content

Commit

Permalink
test: fix test-memory-usage.js for IBMi
Browse files Browse the repository at this point in the history
Newly added process.memoryUsage.rss() will presumably return 0 on IBMi
the same way process.memoryUsage().rss does. Allow IBMi to skip the new
assertion.

The test was using a mix of `assert()` and `assert.ok()`. This change
makes it consistently use `assert.ok()`.

PR-URL: #36758
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
  • Loading branch information
Trott authored and MylesBorins committed Aug 31, 2021
1 parent 0c469b3 commit 815d59a
Showing 1 changed file with 6 additions and 5 deletions.
11 changes: 6 additions & 5 deletions test/parallel/test-memory-usage.js
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,11 @@ const assert = require('assert');

const r = process.memoryUsage();
// On IBMi, the rss memory always returns zero
if (!common.isIBMi)
if (!common.isIBMi) {
assert.ok(r.rss > 0);
assert.ok(process.memoryUsage.rss() > 0);
}

assert.ok(r.heapTotal > 0);
assert.ok(r.heapUsed > 0);
assert.ok(r.external > 0);
Expand All @@ -39,10 +42,8 @@ if (r.arrayBuffers > 0) {
const ab = new ArrayBuffer(size);

const after = process.memoryUsage();
assert(after.external - r.external >= size,
`${after.external} - ${r.external} >= ${size}`);
assert.ok(after.external - r.external >= size,
`${after.external} - ${r.external} >= ${size}`);
assert.strictEqual(after.arrayBuffers - r.arrayBuffers, size,
`${after.arrayBuffers} - ${r.arrayBuffers} === ${size}`);
}

assert(process.memoryUsage.rss() > 0);

0 comments on commit 815d59a

Please sign in to comment.