util: fix inspecting symbol key in string

PR-URL: #11672 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
nodejs · Mar 7, 2017 · 7b84363 · 7b84363
1 parent 8402888
commit 7b84363
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/lib/util.js b/lib/util.js
@@ -396,6 +396,10 @@ function formatValue(ctx, value, recurseTimes) {
     // for boxed Strings, we have to remove the 0-n indexed entries,
     // since they just noisy up the output and are redundant
     keys = keys.filter(function(key) {
+      if (typeof key === 'symbol') {
+        return true;
+      }
+
       return !(key >= 0 && key < raw.length);
     });
   }

diff --git a/test/parallel/test-util-inspect.js b/test/parallel/test-util-inspect.js
@@ -50,6 +50,9 @@ assert.strictEqual(util.inspect(Object.create({},
   {visible: {value: 1, enumerable: true}, hidden: {value: 2}})),
                    '{ visible: 1 }'
 );
+assert.strictEqual(util.inspect(Object.assign(new String('hello'),
+                   { [Symbol('foo')]: 123 }), { showHidden: true }),
+                   '{ [String: \'hello\'] [length]: 5, [Symbol(foo)]: 123 }');
 
 {
   const regexp = /regexp/;