stream: eos premature close

nodejs · Aug 9, 2019 · 77ff0d3 · 77ff0d3
1 parent 885c644
commit 77ff0d3
Show file tree

Hide file tree

Showing 2 changed files with 29 additions and 7 deletions.
diff --git a/lib/internal/streams/end-of-stream.js b/lib/internal/streams/end-of-stream.js
@@ -35,14 +35,22 @@ function eos(stream, opts, callback) {
     if (!stream.writable) onfinish();
   };
 
-  var writableEnded = stream._writableState && stream._writableState.finished;
+  var writableFinished = (
+    stream._writableState &&
+    stream._writableState.finished
+  );
+
   const onfinish = () => {
     writable = false;
-    writableEnded = true;
+    writableFinished = true;
     if (!readable) callback.call(stream);
   };
 
-  var readableEnded = stream._readableState && stream._readableState.endEmitted;
+  var readableEnded = (
+    stream._readableState &&
+    stream._readableState.endEmitted
+  );
+
   const onend = () => {
     readable = false;
     readableEnded = true;
@@ -56,12 +64,12 @@ function eos(stream, opts, callback) {
   const onclose = () => {
     let err;
     if (readable && !readableEnded) {
-      if (!stream._readableState || !stream._readableState.ended)
+      if (!stream._readableState || !stream._readableState.endEmitted)
         err = new ERR_STREAM_PREMATURE_CLOSE();
       return callback.call(stream, err);
     }
-    if (writable && !writableEnded) {
-      if (!stream._writableState || !stream._writableState.ended)
+    if (writable && !writableFinished) {
+      if (!stream._writableState || !stream._writableState.finished)
         err = new ERR_STREAM_PREMATURE_CLOSE();
       return callback.call(stream, err);
     }

diff --git a/test/parallel/test-stream-finished.js b/test/parallel/test-stream-finished.js
@@ -96,6 +96,18 @@ const { promisify } = require('util');
   }));
 }
 
+{
+  const rs = new Readable();
+
+  finished(rs, common.mustCall((err) => {
+    assert(err, 'premature close error');
+  }));
+
+  rs.push(null);
+  rs.emit('close');
+  rs.resume();
+}
+
 {
   const rs = new Readable();
 
@@ -104,7 +116,9 @@ const { promisify } = require('util');
   }));
 
   rs.push(null);
-  rs.emit('close'); // Should not trigger an error
+  rs.on('end', common.mustCall(() => {
+    rs.emit('close'); // Should not trigger an error
+  }));
   rs.resume();
 }