Draft: more IPv6 fixes

test/common/inspector-helper.js

@@ -364,7 +364,7 @@ class NodeInstance extends EventEmitter {
 
   static async startViaSignal(scriptContents) {
     const instance = new NodeInstance(
-      ['--expose-internals'],
+      ['--inspect=localhost', '--expose-internals'],
       `${scriptContents}\nprocess._rawDebug('started');`, undefined);
     const msg = 'Timed out waiting for process to start';
     while (await fires(instance.nextStderrString(), msg, TIMEOUT) !==

test/parallel/test-http-localaddress.js

@@ -44,7 +44,7 @@ server.listen(0, 'localhost', () => {
                     port: server.address().port,
                     path: '/',
                     method: 'GET',
-                    localAddress: 'localhost' };
+                    localAddress: '::1' };
 
   const req = http.request(options, function(res) {
     res.on('end', () => {

test/parallel/test-http2-connect-options.js

@@ -25,7 +25,7 @@ server.listen(0, 'localhost', common.mustCall(() => {
   const options = { localAddress: 'localhost' };
 
   const client = http2.connect(
-    'http://localhost:' + server.address().port,
+    'http://[::1]:' + server.address().port,
     options
   );
   const req = client.request({

test/parallel/test-https-localaddress.js

@@ -54,7 +54,7 @@ server.listen(0, 'localhost', function() {
     port: this.address().port,
     path: '/',
     method: 'GET',
-    localAddress: 'localhost',
+    localAddress: '::1',
     rejectUnauthorized: false
   };
 

test/parallel/test-inspect-async-hook-setup-at-inspect.js

@@ -45,7 +45,7 @@ async function checkAsyncStackTrace(session) {
 }
 
 async function runTests() {
-  const instance = new NodeInstance(['--inspect=::1'], script);
+  const instance = new NodeInstance(['--inspect=localhost'], script);
   const session = await instance.connectInspectorSession();
   await session.send([
     { 'method': 'Runtime.enable' },

test/parallel/test-inspect-publish-uid.js

@@ -18,7 +18,7 @@ async function testArg(argValue) {
   const hasStderr = argValue.split(',').includes('stderr');
 
   const nodeProcess = spawnSync(process.execPath, [
-    '--inspect=0',
+    '--inspect=localhost:0',
     `--inspect-publish-uid=${argValue}`,
     '-e', `(${scriptMain.toString()})(${hasHttp ? 200 : 404})`
   ]);

test/parallel/test-inspector-esm.js

@@ -98,7 +98,7 @@ async function testBreakpoint(session) {
 }
 
 async function runTest() {
-  const child = new NodeInstance(['--inspect-brk=localhost'], '',
+  const child = new NodeInstance(['--inspect-brk=localhost:0'], '',
                                  fixtures.path('es-modules/loop.mjs'));
 
   const session = await child.connectInspectorSession();

test/parallel/test-inspector-waiting-for-disconnect.js

@@ -12,7 +12,8 @@ function mainContextDestroyed(notification) {
 }
 
 async function runTest() {
-  const child = new NodeInstance(['--inspect-brk=0', '-e', 'process.exit(55)']);
+  const child = new NodeInstance(['--inspect-brk=localhost:0', '-e',
+                                  'process.exit(55)']);
   const session = await child.connectInspectorSession();
   const oldStyleSession = await child.connectInspectorSession();
   await oldStyleSession.send([

test/parallel/test-tcp-wrap-connect.js

@@ -14,7 +14,7 @@ function makeConnection() {
   const client = new TCP(TCPConstants.SOCKET);
 
   const req = new TCPConnectWrap();
-  const err = client.connect(req, '127.0.0.1', this.address().port);
+  const err = client.connect(req, '::1', this.address().port);
   assert.strictEqual(err, 0);
 
   req.oncomplete = function(status, client_, req_, readable, writable) {

test/parallel/test-tcp-wrap-listen.js

@@ -14,7 +14,7 @@ const {
 
 const server = new TCP(TCPConstants.SOCKET);
 
-const r = server.bind('0.0.0.0', 0);
+const r = server.bind('::1', 0);
 assert.strictEqual(r, 0);
 let port = {};
 server.getsockname(port);

test/sequential/test-cluster-inspect-brk.js

@@ -29,8 +29,8 @@ if (cluster.isPrimary) {
     }));
   }
 
-  test(['--inspect-brk']);
-  test([`--inspect-brk=${debuggerPort}`]);
+  test(['--inspect-brk=localhost']);
+  test([`--inspect-brk=localhost:${debuggerPort}`]);
 } else {
   // Cluster worker is at a breakpoint, should not reach here.
   assert.fail('Test failed: cluster worker should be at a breakpoint.');

test/sequential/test-https-connect-localport.js

@@ -17,10 +17,10 @@ const assert = require('assert');
     res.end();
   }));
 
-  server.listen(0, 'localhost', common.mustCall(() => {
+  server.listen(0, '::1', common.mustCall(() => {
     const port = server.address().port;
     const req = https.get({
-      host: 'localhost',
+      host: '::1',
       pathname: '/',
       port,
       family: 4,

test/sequential/test-inspector-break-when-eval.js

@@ -62,7 +62,7 @@ async function stepOverConsoleStatement(session) {
 async function runTests() {
   // NOTE(mmarchini): Use --inspect-brk to improve avoid undeterministic
   // behavior.
-  const child = new NodeInstance(['--inspect-brk=0'], undefined, script);
+  const child = new NodeInstance(['--inspect-brk=localhost'], undefined, script);
   const session = await child.connectInspectorSession();
   await setupDebugger(session);
   await breakOnLine(session);

test/sequential/test-inspector-console.js

@@ -8,7 +8,7 @@ const assert = require('assert');
 
 async function runTest() {
   const script = 'require(\'inspector\').console.log(\'hello world\');';
-  const child = new NodeInstance('--inspect-brk=0', script, '');
+  const child = new NodeInstance('--inspect-brk=localhost:0', script, '');
 
   let out = '';
   child.on('stdout', (line) => out += line);

test/sequential/test-inspector-debug-end.js

@@ -14,7 +14,7 @@ async function testNoServerNoCrash() {
 
 async function testNoSessionNoCrash() {
   console.log('Test there\'s no crash stopping server without connecting');
-  const instance = new NodeInstance('--inspect=0',
+  const instance = new NodeInstance('--inspect=localhost:0',
                                     'process._debugEnd();process.exit(42);');
   strictEqual((await instance.expectShutdown()).exitCode, 42);
 }
@@ -28,7 +28,7 @@ async function testSessionNoCrash() {
                       process.exit(42);
                   });`;
 
-  const instance = new NodeInstance('--inspect-brk=0', script);
+  const instance = new NodeInstance('--inspect-brk=localhost:0', script);
   const session = await instance.connectInspectorSession();
   await session.send({ 'method': 'Runtime.runIfWaitingForDebugger' });
   await session.waitForServerDisconnect();

test/sequential/test-inspector-ip-detection.js

@@ -30,7 +30,7 @@ function pickIPv4Address() {
 }
 
 async function test() {
-  const instance = new NodeInstance('--inspect-brk=[::]:0');
+  const instance = new NodeInstance('--inspect-brk=localhost:0');
   try {
     checkIpAddress(ip, await instance.httpGet(ip, '/json/list'));
   } catch (error) {

test/sequential/test-inspector-not-blocked-on-idle.js

@@ -5,7 +5,7 @@ const { NodeInstance } = require('../common/inspector-helper.js');
 
 async function runTests() {
   const script = 'setInterval(() => {debugger;}, 60000);';
-  const node = new NodeInstance('--inspect=0', script);
+  const node = new NodeInstance('--inspect=localhost', script);
   // 1 second wait to make sure the inferior began running the script
   await new Promise((resolve) => setTimeout(() => resolve(), 1000));
   const session = await node.connectInspectorSession();

test/sequential/test-inspector-scriptparsed-context.js

@@ -43,7 +43,7 @@ async function checkScriptContext(session, context) {
 }
 
 async function runTests() {
-  const instance = new NodeInstance(['--inspect-brk=0', '--expose-internals'],
+  const instance = new NodeInstance(['--inspect-brk=localhost:0', '--expose-internals'],
                                     script);
   const session = await instance.connectInspectorSession();
   await session.send([

test/sequential/test-inspector-stop-profile-after-done.js

@@ -5,7 +5,7 @@ const assert = require('assert');
 const { NodeInstance } = require('../common/inspector-helper.js');
 
 async function runTests() {
-  const child = new NodeInstance(['--inspect-brk=0'],
+  const child = new NodeInstance(['--inspect-brk=localhost:0'],
                                  `let c = 0;
                                   const interval = setInterval(() => {
                                    console.log(new Object());

test/sequential/test-net-better-error-messages-port.js

@@ -10,5 +10,5 @@ c.on('connect', common.mustNotCall());
 c.on('error', common.mustCall(function(e) {
   assert.strictEqual(e.code, 'ECONNREFUSED');
   assert.strictEqual(e.port, common.PORT);
-  assert.match(e.address, '/^127\.0\.0\.1$|^::1$/'); // eslint-disable-line
+  assert.match(e.address, /^127\.0\.0\.1$|^::1$/); // eslint-disable-line
 }));