src: break out of timers loop if !can_call_into_js()

Otherwise, this turns into an infinite loop when the flag is set, because it makes `MakeCallback()` return immediately.
nodejs · May 22, 2018 · 5f84afe · 5f84afe
1 parent 23a56e0
commit 5f84afe
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/src/timer_wrap.cc b/src/timer_wrap.cc
@@ -134,7 +134,9 @@ class TimerWrap : public HandleWrap {
     do {
       ret = wrap->MakeCallback(env->timers_callback_function(), 1, args)
                 .ToLocalChecked();
-    } while (ret->IsUndefined() && !env->tick_info()->has_thrown());
+    } while (ret->IsUndefined() &&
+             !env->tick_info()->has_thrown() &&
+             env->can_call_into_js());
   }
 
   static void Now(const FunctionCallbackInfo<Value>& args) {