Skip to content

Commit

Permalink
deps: backport use strict fix for V8 debugger
Browse files Browse the repository at this point in the history
Backport 2ad2237507c5b5f9047b8d94d2f4997327eae852 from V8.

Original commit message:

  Fix Unhandled ReferenceError in debug-debugger.js

  This fixes following exception in Sky on attempt to set a breakpoint
  "Unhandled: Uncaught ReferenceError: break_point is not defined"
  I think this happens in Sky but not in Chrome because Sky scripts are executed in strict mode.

  BUG=None
  LOG=N
  R=yangguo@chromium.org

  Review URL: https://codereview.chromium.org/741683002

  Cr-Commit-Position: refs/heads/master@{#25415}

Reviewed-By: Trevor Norris <trev.norris@gmail.com>
PR-URL: nodejs/node-v0.x-archive#18206
  • Loading branch information
yury-s authored and Julien Gilli committed Apr 29, 2015
1 parent 9a960c2 commit 5b2bf92
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion deps/v8/src/debug-debugger.js
Original file line number Diff line number Diff line change
Expand Up @@ -430,7 +430,7 @@ ScriptBreakPoint.prototype.set = function (script) {
if (IS_NULL(position)) return;

// Create a break point object and set the break point.
break_point = MakeBreakPoint(position, this);
var break_point = MakeBreakPoint(position, this);
break_point.setIgnoreCount(this.ignoreCount());
var actual_position = %SetScriptBreakPoint(script, position,
this.position_alignment_,
Expand Down

0 comments on commit 5b2bf92

Please sign in to comment.