esm: fix misleading when import empty package.json

nodejs · Sep 20, 2023 · 57dc1e2 · 57dc1e2
1 parent e9ff810
commit 57dc1e2
Show file tree

Hide file tree

Showing 3 changed files with 30 additions and 0 deletions.
diff --git a/lib/internal/modules/esm/resolve.js b/lib/internal/modules/esm/resolve.js
@@ -183,6 +183,12 @@ function legacyMainResolve(packageJSONUrl, packageConfig, base) {
 
   const baseStringified = isURL(base) ? base.href : base;
 
+  if (typeof packageConfig.main !== 'string') {
+    throw new ERR_INVALID_PACKAGE_CONFIG(
+      fileURLToPath(packageJSONUrl), base,
+      '"main" must be a string', 'main');
+  }
+
   const resolvedOption = FSLegacyMainResolve(packageJsonUrlString, packageConfig.main, baseStringified);
 
   const baseUrl = resolvedOption <= legacyMainResolveExtensionsIndexes.kResolvedByMainIndexNode ? `./${packageConfig.main}` : '';

diff --git a/test/es-module/test-import-empty.js b/test/es-module/test-import-empty.js
@@ -0,0 +1,23 @@
+'use strict';
+
+const { spawnPromisified } = require('../common');
+const fixtures = require('../common/fixtures.js');
+const assert = require('node:assert');
+const { execPath } = require('node:process');
+const { describe, it } = require('node:test');
+
+describe('Import empty module', { concurrency: true }, () => {
+  it(async () => {
+    const { code, signal, stdout, stderr } = await spawnPromisified(execPath, [
+      '--no-warnings',
+      '--eval',
+      'import("empty")',
+    ], {
+      cwd: fixtures.path(),
+    });
+    assert.strictEqual(code, 1);
+    assert.strictEqual(signal, null);
+    assert.strictEqual(stdout, '');
+    assert.match(stderr, /Error \[ERR_INVALID_PACKAGE_CONFIG]: Invalid package config/);
+  });
+});
diff --git a/test/fixtures/node_modules/empty/package.json b/test/fixtures/node_modules/empty/package.json