Skip to content

Commit

Permalink
util: Remove exec, has been deprecated for years
Browse files Browse the repository at this point in the history 
PR-URL: #2530
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
  • Loading branch information
@geek @jasnell
geek authored and jasnell committed Nov 18, 2015
1 parent e4e5b13 commit 4cf19ad
Showing 1 changed file with 0 additions and 5 deletions.
5 changes: 0 additions & 5 deletions lib/util.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -838,11 +838,6 @@ function hasOwnProperty(obj, prop) {

// Deprecated old stuff.

exports.exec = internalUtil.deprecate(function() {
return require('child_process').exec.apply(this, arguments);
}, 'util.exec is deprecated. Use child_process.exec instead.');


exports.print = internalUtil.deprecate(function() {
for (var i = 0, len = arguments.length; i < len; ++i) {
process.stdout.write(String(arguments[i]));
Expand Down

5 comments on commit 4cf19ad

@cjihrig
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove should be remove in the commit title

@jasnell
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doh! dangnabbit!!

@Fishrock123
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Umm, does that really matter? I've seen lots of commits with both?

@jasnell
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not critical but it's good to be consistent. Only I keep not being lol

@cjihrig
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it's not explicitly called out in CONTRIBUTING.md. I thought it was. The example there uses all starts with lowercase. If that's not the policy, then sorry for the false alarm :-)

Please sign in to comment.