quic: address review comments

src/quic/defs.h

@@ -39,8 +39,7 @@ bool SetOption(Environment* env,
       if (!lossless) {
         Utf8Value label(env->isolate(), name);
         THROW_ERR_OUT_OF_RANGE(
-            env,
-            (std::string("options.") + (*label) + " is out of range").c_str());
+            env, ("options." + label.ToString() + " is out of range").c_str());
         return false;
       }
     } else {

src/quic/logstream.cc

@@ -84,7 +84,7 @@ void LogStream::Emit(const uint8_t* data, size_t len, EmitOption option) {
 }
 
 void LogStream::Emit(const std::string_view line, EmitOption option) {
-  Emit(reinterpret_cast<const uint8_t*>(line.begin()), line.length(), option);
+  Emit(reinterpret_cast<const uint8_t*>(line.data()), line.length(), option);
 }
 
 void LogStream::End() {

src/quic/logstream.h

@@ -67,6 +67,9 @@ class LogStream : public AsyncWrap, public StreamBase {
   bool reading_ = false;
   std::deque<Chunk> buffer_;
 
+  // The value here is fairly arbitrary. Once we get everything
+  // fully implemented and start working with this, we might
+  // tune this number further.
   static constexpr size_t kMaxLogStreamBuffer = 1024 * 10;
 
   // The LogStream buffer enforces a maximum size of kMaxLogStreamBuffer.

src/quic/transportparams.cc

@@ -178,9 +178,8 @@ void TransportParams::GenerateStatelessResetToken(
 }
 
 CID TransportParams::GeneratePreferredAddressToken(const Session& session) {
-  DCHECK_NOT_NULL(session);
   DCHECK(ptr_ == &params_);
-  DCHECK(pscid);
+  // DCHECK(pscid);
   // TODO(@jasnell): To be implemented when Session is implemented
   // *pscid = session->cid_factory_.Generate();
   // params_.preferred_address.cid = *pscid;

src/quic/transportparams.h

@@ -51,8 +51,8 @@ class TransportParams final {
     // address and port that the server would prefer the client to use when
     // communicating with it. See the QUIC specification for more detail on how
     // the preferred address mechanism works.
-    std::optional<SocketAddress> preferred_address_ipv4 = std::nullopt;
-    std::optional<SocketAddress> preferred_address_ipv6 = std::nullopt;
+    std::optional<SocketAddress> preferred_address_ipv4{};
+    std::optional<SocketAddress> preferred_address_ipv6{};
 
     // The initial size of the flow control window of locally initiated streams.
     // This is the maximum number of bytes that the *remote* endpoint can send

test/sequential/test-async-wrap-getasyncid.js

@@ -66,6 +66,7 @@ const { getSystemErrorName } = require('util');
     delete providers.BLOBREADER;
     delete providers.RANDOMPRIMEREQUEST;
     delete providers.CHECKPRIMEREQUEST;
+    delete providers.QUIC_LOGSTREAM;
 
     const objKeys = Object.keys(providers);
     if (objKeys.length > 0)