Skip to content

Commit

Permalink
deps: update default openssl.cnf directory
Browse files Browse the repository at this point in the history 
Update default openssl.cnf directory on linux to be consistent with
older versions

Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: RafaelGSS <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
PR-URL: nodejs-private/node-private#335
CVE-ID: CVE-2022-32222
  • Loading branch information
@mhdawson @RafaelGSS
mhdawson authored and RafaelGSS committed Jul 7, 2022
1 parent 1aa5036 commit 46093c4
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions deps/openssl/openssl_common.gypi
View file
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@
# linux and others
'cflags': ['-Wno-missing-field-initializers',],
'defines': [
'OPENSSLDIR="/etc/ssl"',
'ENGINESDIR="/dev/null"',
'TERMIOS',
],
Expand Down

2 comments on commit 46093c4

@lpinca
Copy link
Member

@lpinca lpinca commented on 46093c4 Aug 25, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that the following warning on Ubuntu 22.04

<command-line>: warning: "OPENSSLDIR" redefined
<command-line>: note: this is the location of the previous definition

is raised by this change. Is it needed?

@RafaelGSS
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that's needed to fix a vulnerability. I think we can suppress the warning somehow. cc: @mhdawson

Please sign in to comment.