Skip to content

Commit

Permalink
test: check number of message events
Browse files Browse the repository at this point in the history
When a no-op message event handler is used in a test, make it clear what
is expected by using `common.mustCall()` and `common.mustNotCall()`.

PR-URL: #13125
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <mhdawson@ibm.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
  • Loading branch information
Trott authored and MylesBorins committed Aug 14, 2017
1 parent 9dde328 commit 4072073
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions test/parallel/test-child-process-fork-ref2.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
'use strict';
require('../common');
const common = require('../common');
const fork = require('child_process').fork;

if (process.argv[2] === 'child') {
Expand All @@ -8,7 +8,7 @@ if (process.argv[2] === 'child') {

setTimeout(function() {
console.log('child -> will this keep it alive?');
process.on('message', function() { });
process.on('message', common.mustNotCall());
}, 400);

} else {
Expand Down
2 changes: 1 addition & 1 deletion test/sequential/test-child-process-pass-fd.js
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ if (process.argv[2] !== 'child') {
// the only thing keeping this worker alive will be IPC. This is important,
// because it means a worker with no parent will have no referenced handles,
// thus no work to do, and will exit immediately, preventing process leaks.
process.on('message', common.noop);
process.on('message', common.mustCall());

const server = net.createServer((c) => {
process.once('message', function(msg) {
Expand Down

0 comments on commit 4072073

Please sign in to comment.