worker: inherits mutated NODE_OPTIONS

nodejs · Sep 20, 2022 · 3571383 · 3571383
1 parent 5e3d003
commit 3571383
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 1 deletion.
diff --git a/lib/internal/worker.js b/lib/internal/worker.js
@@ -189,7 +189,7 @@ class Worker extends EventEmitter {
 
     // Set up the C++ handle for the worker, as well as some internal wiring.
     this[kHandle] = new WorkerImpl(url,
-                                   env === process.env ? null : env,
+                                   env,
                                    options.execArgv,
                                    parseResourceLimits(options.resourceLimits),
                                    !!(options.trackUnmanagedFds ?? true));

diff --git a/test/parallel/test-worker-process-env-options.js b/test/parallel/test-worker-process-env-options.js
@@ -0,0 +1,14 @@
+'use strict';
+const { Worker } = require('node:worker_threads');
+
+if (!require.main) {
+  globalThis.setup = true;
+} else {
+  process.env.NODE_OPTIONS ??= ``;
+  process.env.NODE_OPTIONS += ` --require ${JSON.stringify(__filename)}`;
+
+  new Worker(`
+    const assert = require('assert');
+    assert.strictEqual(globalThis.setup, true);
+  `, { eval: true });
+}